Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unicode.Char.Case.Compat #53

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

wismill
Copy link
Collaborator

@wismill wismill commented Dec 21, 2021

Add Unicode.Char.Case.Compat with toLower, toUpper and toTitle functions.

Fix UnicodeData.txt parsing.

This fixes the missing functions for drop-in replacement of Data.Char (see #47).

@harendra-kumar
Copy link
Member

I am wondering if we should have a single Unicode.Char.Compat module instead of multiple compat modules in order to reduce the number of modules.

@wismill
Copy link
Collaborator Author

wismill commented Dec 21, 2021

I am wondering if we should have a single Unicode.Char.Compat module instead of multiple compat modules in order to reduce the number of modules.

I think this is the last Compat module; two of such modules seems reasonable.

@adithyaov
Copy link
Member

Looks good!

@wismill
Copy link
Collaborator Author

wismill commented Dec 22, 2021

I added benchmarks. We get a nice 3× speedup compared to base.

@wismill wismill merged commit 5d1ff06 into composewell:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants