Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full case conversions #77

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Add full case conversions #77

merged 5 commits into from
Sep 14, 2022

Conversation

wismill
Copy link
Collaborator

@wismill wismill commented Jul 9, 2022

Add full case conversions as in text. It does not cover context- nor locale-dependent conversions.

See #47.

@wismill wismill force-pushed the wip/better_case_conversion branch from a11372b to 2a8506f Compare July 9, 2022 16:59
Copy link
Member

@adithyaov adithyaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, Apologies for the extremely delayed review.

Remove blank line

Co-authored-by: Adithya Kumar <adithya@composewell.com>
@wismill
Copy link
Collaborator Author

wismill commented Sep 13, 2022

@harendra-kumar I will merge this tomorrow if there is no further comment.

Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just missed this PR. The change looks pretty good. I have a few minor suggestions.

unicode-data/lib/Unicode/Internal/Unfold.hs Show resolved Hide resolved
unicode-data/lib/Unicode/Char/Case.hs Outdated Show resolved Hide resolved
unicode-data/lib/Unicode/Char/Case.hs Show resolved Hide resolved
unicode-data/lib/Unicode/Char/Case.hs Show resolved Hide resolved
unicode-data/lib/Unicode/Char/Case.hs Show resolved Hide resolved
unicode-data/lib/Unicode/Char/Case.hs Outdated Show resolved Hide resolved
@wismill wismill merged commit 19119ad into master Sep 14, 2022
@wismill wismill deleted the wip/better_case_conversion branch September 26, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants