-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full case conversions #77
Conversation
a11372b
to
2a8506f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, Apologies for the extremely delayed review.
Remove blank line Co-authored-by: Adithya Kumar <adithya@composewell.com>
@harendra-kumar I will merge this tomorrow if there is no further comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just missed this PR. The change looks pretty good. I have a few minor suggestions.
Add full case conversions as in
text
. It does not cover context- nor locale-dependent conversions.See #47.