-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax upper bound for base, allowing base-4.17.* #78
Conversation
.github/workflows/haskell.yml
Outdated
@@ -51,6 +51,7 @@ jobs: | |||
- 8.10.7+exe | |||
- 9.0.1+exe | |||
- 9.2.1 | |||
- 9.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need add a corresponding entry in the include
section below. CIs are not getting started because of this issue.
Also we can bump the minor version to 9.4.2 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed that this is only the name
. Should be fixed now.
8c80be9
to
1029665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This:
- uses: haskell/actions/setup@v1
with:
ghc-version: ${{ matrix.ghc_version }}
cabal-version: ${{ matrix.cabal_version }}
Seems to have an issue installing cabal-3.8. We can try changing the version to full 3.8.1.0 and see if that works.
It is getting installed but somehow it is not able to find it:
ghcup seems to be succeeding but perhaps there is an issue with the setup action script, it thinks there was an error. |
Ah, the problem is with
I think we need to provide the full version 3.8.1.0 to this command? Maybe if in our CI config we change the version to 3.8.1.0 it might work. |
This allows to build with GHC 9.4.
I setup my fork to run the tests, and they pass now. |
Since there are no other changes required let's merge this and make a revision on hackage. |
This allows to build with GHC 9.4.