Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax upper bound for base, allowing base-4.17.* #78

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

tarleb
Copy link
Contributor

@tarleb tarleb commented Aug 24, 2022

This allows to build with GHC 9.4.

@@ -51,6 +51,7 @@ jobs:
- 8.10.7+exe
- 9.0.1+exe
- 9.2.1
- 9.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add a corresponding entry in the include section below. CIs are not getting started because of this issue.

Also we can bump the minor version to 9.4.2 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that this is only the name. Should be fixed now.

@tarleb tarleb force-pushed the ghc-9.4 branch 2 times, most recently from 8c80be9 to 1029665 Compare August 31, 2022 07:09
Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This:

    - uses: haskell/actions/setup@v1
      with:
        ghc-version: ${{ matrix.ghc_version }}
cabal-version: ${{ matrix.cabal_version }}

Seems to have an issue installing cabal-3.8. We can try changing the version to full 3.8.1.0 and see if that works.

@harendra-kumar
Copy link
Member

It is getting installed but somehow it is not able to find it:

  [ Info  ] verifying digest of: cabal-install-3.8.1.0-x86_64-linux-alpine.tar.xz
  [ Info  ] Unpacking: cabal-install-3.8.1.0-x86_64-linux-alpine.tar.xz to /tmp/ghcup-750e3a0e87a57afb
  [ Info  ] Installing cabal
  [ Info  ] Cabal installation successful
  /opt/hostedtoolcache/ghcup/0.1.17.6/x64/ghcup set cabal 3.8
  [ Error ] The version 3.8 of the tool cabal is not installed.
  Attempting to install cabal-install 3.8 using apt-get

ghcup seems to be succeeding but perhaps there is an issue with the setup action script, it thinks there was an error.

@harendra-kumar
Copy link
Member

Ah, the problem is with ghcup set cabal:

  /opt/hostedtoolcache/ghcup/0.1.17.6/x64/ghcup set cabal 3.8
  [ Error ] The version 3.8 of the tool cabal is not installed.

I think we need to provide the full version 3.8.1.0 to this command? Maybe if in our CI config we change the version to 3.8.1.0 it might work.

This allows to build with GHC 9.4.
@tarleb
Copy link
Contributor Author

tarleb commented Aug 31, 2022

I setup my fork to run the tests, and they pass now.

@harendra-kumar
Copy link
Member

Since there are no other changes required let's merge this and make a revision on hackage.

@harendra-kumar harendra-kumar merged commit f8f6d2b into composewell:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants