Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new package unicode-data-security #84

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Add new package unicode-data-security #84

merged 3 commits into from
Sep 21, 2022

Conversation

wismill
Copy link
Collaborator

@wismill wismill commented Sep 16, 2022 •
edited

Unicode Security Mechanisms functions based on Unicode Technical Standard #39.

  • Download files.
  • Add generator for unintentional confusables.
  • Add generator for intentional confusables.
  • Add generator for Identifier_Type.
  • Add generator for Identifier_Status.

@wismill
Copy link
Collaborator Author

wismill commented Sep 17, 2022

Rebased

harendra-kumar
harendra-kumar reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have much idea about this. Just had a quick look at the structure of the package and the code. Just a few suggestions.

unicode-data-security/lib/Unicode/Char/Identifiers/Security.hs Outdated Show resolved Hide resolved
unicode-data-security/lib/Unicode/Char/Identifiers/Security.hs Outdated Show resolved Hide resolved
unicode-data-security/lib/Unicode/Char/Identifiers/Security.hs Outdated Show resolved Hide resolved
unicode-data-security/lib/Unicode/Char/Identifiers/Security.hs Show resolved Hide resolved
@harendra-kumar
Copy link
Member

BTW, are you using this stuff somewhere? What is the primary motivation for this enhancement?

@wismill
Copy link
Collaborator Author

wismill commented Sep 21, 2022 •
edited

BTW, are you using this stuff somewhere? What is the primary motivation for this enhancement?

@harendra-kumar I would like to have the data available to be able to work on the Unicode Security Mechanisms. A new library such as unicode-security would be nice.

@wismill
Add new package unicode-data-security
bb2888e 
- Download files.
- Add generator for unintentional confusables.
- Add generator for intentional confusables.
- Add generator for Identifier_Type.
- Add generator for Identifier_Status.
@wismill
Review fixes
27374ed
@wismill
isAllowedIdentifier → isAllowedInIdentifier
b319d58
@wismill wismill merged commit adbd767 into master Sep 21, 2022
@wismill wismill deleted the wip/security branch September 26, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harendra-kumar harendra-kumar harendra-kumar approved these changes

@adithyaov adithyaov Awaiting requested review from adithyaov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wismill @harendra-kumar