Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Unicode 15.0.0 #92

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Update to Unicode 15.0.0 #92

merged 7 commits into from
Oct 11, 2022

Conversation

wismill
Copy link
Collaborator

@wismill wismill commented Sep 27, 2022

Update to Unicode 15.0.0.

Fixes #85.

@wismill
Copy link
Collaborator Author

wismill commented Sep 27, 2022

Note that since this version is not supported yet by any published GHC version, you need to use GHC HEAD or one of my MR to run the tests and benchmark properly.

@wismill wismill mentioned this pull request Sep 27, 2022
4 tasks
@wismill
Copy link
Collaborator Author

wismill commented Sep 28, 2022

Rebased

@wismill
Copy link
Collaborator Author

wismill commented Oct 6, 2022

@harendra-kumar kind reminder

@harendra-kumar
Copy link
Member

Looks good to me. Though I only took a quick look, and I did not verify if we actually took the right unicode sources to generate the code. @adithyaov would you like to take a look as well?

Copy link
Member

@adithyaov adithyaov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wismill wismill merged commit 5c5013f into master Oct 11, 2022
@wismill
Copy link
Collaborator Author

wismill commented Oct 11, 2022

@wismill
Copy link
Collaborator Author

wismill commented Oct 13, 2022

@harendra-kumar @adithyaov candidates published

@harendra-kumar
Copy link
Member

@wismill I cannot find the candidates, the links above do not work.

@wismill
Copy link
Collaborator Author

wismill commented Oct 13, 2022

@harendra-kumar I mean I published the new version, after the candidate stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Unicode 15.0.0
3 participants