Add a raw bitmap lookup function #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got some more performance boost by: * Removing dynamic word size handling. We now use a static 64-bit word size. We can possibly add a 32-bit version as well and statically select an appropriate version based on WORD_SIZE_IN_BITS GHC macro. * Removing testBit which caused an additional branch instruction * Refactor `isCombining` such that GHC can reuse code converting char to int
Bodigrim
reviewed
Apr 28, 2020
| -- accessible memory. | ||
| -- | ||
| lookupBit64 :: Addr# -> Int -> Bool | ||
| lookupBit64 addr# (I# index#) = W# (word## `and#` bitMask##) /= 0 |
There was a problem hiding this comment.
Maybe isTrue# (word2Int# (word## and# bitMask##))? Just to be absolutely sure that there are no allocations.
Ah, sorry, my bad, isTrue# does not work here. Nevermind.
| let i = ord c | ||
| in if i < 768 || i > 125258 | ||
| then False | ||
| else combiningBitmap i |
There was a problem hiding this comment.
Is there a reason to prefer this to i >= 768 && i <= 125258 && combiningBitmap i?
There was a problem hiding this comment.
I don't prefer anyone in particular.
|
Looks good to me :) |
|
Thanks! Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some more performance boost by:
can possibly add a 32-bit version as well and statically select an
appropriate version based on WORD_SIZE_IN_BITS GHC macro.
isCombiningsuch that GHC can reuse code converting char to int@Bodigrim please take a look.