New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Unicode 13.0.0 #31
Conversation
It seems that some builds have cached an old one, Unicode 12.1 |
We are currently using an xml file I am wondering if we should switch to the text files - https://www.unicode.org/Public/13.0.0/ucd/ . That will reduce the size and speed significantly because we need only a few of these and git should be able to handle the incremental changes to these files much more efficiently. It requires some effort and testing though. We can consider this when creating a new package for the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you separate the version bump changes to a separate PR? That should be the last commit before we decide to release.
dee1118
to
ed239d9
Compare
@Bodigrim Since the |
ed239d9
to
4f63fb2
Compare
Please note that updating to Unicode 13 did not change anything. The changes are because of executing |
Why would running ucd2haskell before the update change anything at all? Any changes should come after the update. Maybe you had a newer version .pdb lying around in your workspace when you ran it, it may be from your earlier experiments. When I run Can you try cloning the repo in a fresh workspace and run it? |
You're right, I found that strange too. It looks like I messed up. |
4f63fb2
to
673084a
Compare
Is there anything unresolved left? |
It should be mergeable now. |
Closes #28