1. minor update about borrow-erc20-with-eth-collateral 2. add borrowing based reinvestment pattern #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-spengler
changed the title
|
@byrmarkn Thank you for approving the PR. Is there anything else necessary before this PR can be merged? I'm considering to add a smart contract based implementation of this borrowing based reinvestment scenario to the solidity-examples folder. Would this be valuable from your side? Do you have any hints for me on how to do this in a good way? I do not know exactly how long it would take me as I'm relatively new to solidity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just a minor simplification proposal. Your examples saved me a lot of research time --> Thank You.
The second (or subsequent commits) shall propose adding a borrowing based reinvestment pattern example. With this you can easily use / increase the leverage effect when you are e.g. betting on rising ether prices.