Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing pipenv setup virtualenv #272

Merged
merged 23 commits into from
Nov 21, 2020
Merged

Removing pipenv setup virtualenv #272

merged 23 commits into from
Nov 21, 2020

Conversation

bri25yu
Copy link
Contributor

@bri25yu bri25yu commented Nov 13, 2020 •
edited
Loading

Added a minimal development environment setup using virtualenv

  • I didn't extensively test this, i just make migrate then make dev and checked that it worked, pretty much what our TravisCI does lmao (also i removed references in our travis.yaml file that broke our TravisCI whoops)
  • Tried removing all traces of pipenv, but there are a few references in fabfile.py (like James was mentioning before) that I didn't want to touch -- need y'alls input on that

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 13, 2020

This pull request introduces 2 alerts when merging 2a4a17b into 03ffefe - view on LGTM.com

new alerts:

  • 1 for Illegal raise
  • 1 for URL redirection from remote source

jvperrin
jvperrin reviewed Nov 13, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
jvperrin
jvperrin reviewed Nov 13, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
fabfile.py Outdated Show resolved Hide resolved
jameslzhu
jameslzhu reviewed Nov 13, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
fabfile.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Vagrantfile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@bri25yu
Copy link
Contributor Author

bri25yu commented Nov 13, 2020

Made a couple of edits, working more on this tomorrow

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 13, 2020

This pull request introduces 2 alerts when merging dbc36ef into 03ffefe - view on LGTM.com

new alerts:

  • 1 for Illegal raise
  • 1 for URL redirection from remote source

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 13, 2020

This pull request introduces 2 alerts when merging 9c1e889 into 03ffefe - view on LGTM.com

new alerts:

  • 1 for Illegal raise
  • 1 for URL redirection from remote source

jvperrin
jvperrin reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@jvperrin jvperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty good to me, thanks for doing this and I've got just a few more comments but nothing too serious

.travis.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
fabfile.py Outdated Show resolved Hide resolved
@bri25yu
Copy link
Contributor Author

bri25yu commented Nov 15, 2020 •
edited
Loading

Add instructions to README on how to enable dev env e.g. source .venv/bin/activate, make migrate, etc.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 16, 2020

This pull request introduces 2 alerts when merging 7bcf50a into 03ffefe - view on LGTM.com

new alerts:

  • 1 for Illegal raise
  • 1 for URL redirection from remote source

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 16, 2020

This pull request introduces 2 alerts when merging 0276d36 into 03ffefe - view on LGTM.com

new alerts:

  • 1 for Illegal raise
  • 1 for URL redirection from remote source

jameslzhu
jameslzhu reviewed Nov 16, 2020
View reviewed changes
Makefile Show resolved Hide resolved
Vagrantfile Show resolved Hide resolved
fabfile.py Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 16, 2020

This pull request introduces 2 alerts when merging 26ac2ce into 97af670 - view on LGTM.com

new alerts:

  • 1 for Illegal raise
  • 1 for URL redirection from remote source

@bri25yu bri25yu closed this Nov 16, 2020
@bri25yu bri25yu deleted the removing-pipenv-setup-virtualenv branch November 16, 2020 06:54
@jameslzhu
Copy link
Member

Wait you ... closed this without merging commits?

@bri25yu bri25yu restored the removing-pipenv-setup-virtualenv branch November 17, 2020 16:11
@bri25yu bri25yu reopened this Nov 17, 2020
@bri25yu
Copy link
Contributor Author

bri25yu commented Nov 17, 2020

Lmao was cleaning up stale branches and I guess I must've accidentally deleted this branch too

@bri25yu bri25yu merged commit 1c4db22 into compserv:master Nov 21, 2020
@bri25yu bri25yu deleted the removing-pipenv-setup-virtualenv branch December 21, 2021 01:05
@bri25yu bri25yu restored the removing-pipenv-setup-virtualenv branch December 21, 2021 01:05
@bri25yu bri25yu deleted the removing-pipenv-setup-virtualenv branch December 21, 2021 01:05
@bri25yu bri25yu mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvperrin jvperrin jvperrin left review comments

@jameslzhu jameslzhu jameslzhu left review comments

@ochan1 ochan1 Awaiting requested review from ochan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bri25yu @jameslzhu @jvperrin