Add testing #447
Merged
Add testing #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bri25yu
commented
Apr 6, 2022
•
bri25yu
commented
- Add code coverage using coverage.py
- Add Github actions to run python tests and check formatting
- Add MakeFile command to format code
- Fixing some LGTM alerts
- Testing fixes
- event test slug error
- test_tabular missing event type
- test rsvp and unrsvp redirection tests
- confirm rsvp not post 403
- allow_public_access login required bug
- academics api permissions test
- test_confirm status code
- Misc improvements/fixes
- ordering academics api querysets
- fixing course surveys index login error
- fixing accesslevelrequired return None bug
- improving resume review logic
- dept tours slight cleanup, email sending, improving tours html
- merging reviewsessions with events
- improving candidatedto email domain logic
- removing account activate
- Tests added
- resume review
- dept tours
- reviewsessions
- studentservices models
- cand: misc, checkoffs, mass add cands
- tutoring views
- users views
- google calendar utils
|
This pull request introduces 2 alerts and fixes 10 when merging 949fc1a into 65e0004 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 2 alerts and fixes 10 when merging 9acf732 into 65e0004 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 17 when merging 10fa688 into 65e0004 - view on LGTM.com new alerts:
fixed alerts:
|
ochan1
reviewed
Apr 12, 2022
|
|
||
| .PHONY: format | ||
| format: | ||
| python -m black . --exclude "/(.*migrations|\.venv)/" |
There was a problem hiding this comment.
Use $(PYTHON) instead of "python"
| pip install -r requirements-dev.txt | ||
| - name: Running black formatter check | ||
| run: | | ||
| python -m black . --check --exclude "/(.*migrations|\.venv)/" |
There was a problem hiding this comment.
Recommendation: Add the --diff flag to see what needs to be changed (just like back in CS 61B style checking)
python -m black . --check --diff --exclude "/(.*migrations|\.venv)/"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.