PCHR-3742: Disabling or Deleting Options Breaks Job Roles Tab #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpavlov-zz
suggested changes
Jun 1, 2018
| updatedRole.department = (updatedRole.department === undefined) ? updatedRole.department = '' : updatedRole.department; | ||
| updatedRole.region = (updatedRole.region === undefined) ? updatedRole.region = '' : updatedRole.region; | ||
| // Ensure location, level, department, region exist and not disabled | ||
| updateLocation = _.includes(_.keys(vm.LocationsData), updatedRole.location); |
There was a problem hiding this comment.
Please move the code to a separate function with a meaningful name, there is too much duplication.
| updateDepartment = _.includes(_.keys(vm.DepartmentsData), updatedRole.department); | ||
| updateRegion = _.includes(_.keys(vm.RegionsData), updatedRole.region); | ||
|
|
||
| updatedRole.location = (updatedRole.location === undefined || !updateLocation) ? updatedRole.location = '' : updatedRole.location; |
There was a problem hiding this comment.
Please move the code to a separate function with a meaningful name, there is too much duplication.
|
@ajesamson are there JS test suites for JobRoles extension? |
|
@igorpavlov There are JS test suites. |
igorpavlov-zz
suggested changes
Jun 1, 2018
| /** | ||
| * Update submitted role if undefined or option type is disabled | ||
| * | ||
| * @param updatedRole |
There was a problem hiding this comment.
* @param updatedRole
* @param optionData
* @return {Object}
ajesamson
force-pushed
the
PCHR-3742-disabling-deleting-options-breaks-job-roles-tab
branch
from
2347c37
to
d6a280b
Compare
ajesamson
force-pushed
the
PCHR-3742-disabling-deleting-options-breaks-job-roles-tab
branch
from
d6a280b
to
ec9f5f4
Compare
igorpavlov-zz
approved these changes
Jun 1, 2018
ajesamson
deleted the
PCHR-3742-disabling-deleting-options-breaks-job-roles-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes issues with editing disabled or deleted job role option group. Dropdown displays wrongly if such record was previously submitted.
Before
After
Technical Details
Values that are invalid gets submitted as the existing implementation only checks if the value is defined or not. To guide against this, submitted data is checked against valid list of options data.
✅Manual Tests - passed
✅Jasmine Tests - passed
✅JS distributive files - included