Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor protocol HOC integration #77

Closed
thirtyaughtsix opened this issue Aug 1, 2019 · 1 comment
Closed

Refactor protocol HOC integration #77

thirtyaughtsix opened this issue Aug 1, 2019 · 1 comment
Assignees
@thirtyaughtsix
Labels
refactor

Comments

@thirtyaughtsix
Copy link
Contributor

Follow the pattern from #75, #76 and refactor the protocol integration under @/models/protocol out into @/functionModules/protocol
@thirtyaughtsix
Copy link
Contributor Author

thirtyaughtsix commented Aug 1, 2019 •
edited
Loading

So... I'm thinking we need a series of static funs. Like one to instantiate and initialize the HOC class (constructor + at). That would get called from the method fun like list(listingHash: string): string (assuming the tx hash is the return).

@thirtyaughtsix thirtyaughtsix self-assigned this Aug 2, 2019
thirtyaughtsix added a commit that referenced this issue Aug 2, 2019
@thirtyaughtsix
Refactors for #77
86190ae
MelvinMallari pushed a commit that referenced this issue Aug 2, 2019
@thirtyaughtsix @MelvinMallari
Refactors for #77 (#79)
7984f11 
* Refactors for #77

* revert changes to vue.config.js

* remove bad imports
@thirtyaughtsix thirtyaughtsix reopened this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thirtyaughtsix thirtyaughtsix

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thirtyaughtsix