Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix non target_mask calls in demos #102

Closed
LynnSchmittwilken opened this issue Sep 5, 2023 · 0 comments
Closed

fix non target_mask calls in demos #102

LynnSchmittwilken opened this issue Sep 5, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@LynnSchmittwilken
Copy link
Contributor

Is the proposed change to a specific function demo?

One cannot choose non target_masks in the demos for the rings and bullseyes, but the problem might also exist for other demos.
@LynnSchmittwilken LynnSchmittwilken added the documentation Improvements or additions to documentation label Sep 5, 2023
@LynnSchmittwilken LynnSchmittwilken mentioned this issue Sep 5, 2023
Merged
JorisVincent added a commit that referenced this issue Sep 12, 2023
@JorisVincent
fix: rename _masks
3a433b2 
Add a distance-specific mask (`bar_`, `ring_`, `frame_`, `segment_`). These are similarly named in the "generalized" versions of these stimuli (`frames`, `rings`, etc.).
This is just a reference to `grating_mask`, so that will remain consistent between all `wave`-like stimuli.

Closes #102
@JorisVincent JorisVincent mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LynnSchmittwilken