Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lynn issues #3

Merged
merged 48 commits into from
Mar 15, 2023
Merged

Lynn issues #3

merged 48 commits into from
Mar 15, 2023

Conversation

LynnSchmittwilken
Copy link
Contributor

No description provided.

@LynnSchmittwilken
now ignoring folder with original modelfest for testing
25fa0b6
@LynnSchmittwilken
closes #94; fixed all intensity ranges for modelfest. our modelfest n…
99578b2 
…ow perfectly recreates original in all cases but checkerboard
@LynnSchmittwilken
pad_dict utils now also update visual_size and shape keys
86bc84a
@LynnSchmittwilken
plotting functions take argument extent_keys for changing extent para…
dd38b35 
…m of plots
@LynnSchmittwilken
corrected keys for shape and visual_size for stimuli that involved st…
4750caf 
…acking or padding
@LynnSchmittwilken
updated carney1999.json
9a65fc1
@LynnSchmittwilken
renamed carney1999 into modelfest
154cb32
@LynnSchmittwilken
removed oriented noise for now
0fbb166
@LynnSchmittwilken
made filters functions (currently only bandpass) more consistent with…
33e0c02 
… stimupy workflows
@LynnSchmittwilken
fixed bug that parallelogram and ellipse would not contain correct si…
92acc3c 
…ze params in output dict
@LynnSchmittwilken
fixed bug that two_sided dotted sbcs did not contain correct shape an…
16fe40b 
…d visual_size
@LynnSchmittwilken
added all missing docstrings, re-organized utils, replaced degrees_to…
7e37afd 
…_pixels by resolution-funcs
@LynnSchmittwilken
reorganized functions; added resolve_dict and valid_dict
983c11d
@LynnSchmittwilken
corrected resolution docstrings
4b45d56
@LynnSchmittwilken
added utils to get all function argument names, and to strip dictiona…
f1951a8 
…ry from all keys which are not function argument names
@LynnSchmittwilken
corrected docstrings - mask to target_mask
20de701
@LynnSchmittwilken
fixed bug that height and width of extent were switched
1f217f3
@LynnSchmittwilken
fixed bug and added pad_masks when padding dicts
c0e8cec
@LynnSchmittwilken
uncommented two_sided rings
b502b37
@LynnSchmittwilken
added papers bindmann2004
ae39e9b
@LynnSchmittwilken
updated reference in bindmann2004.py
ba09e06
@LynnSchmittwilken
fixed bug of switched extent coords if no extent is passed
9e0e519
@LynnSchmittwilken
plotting functions does not throw an error if it cannot find the mask…
d4eff76 
…, but just skips the mask
@LynnSchmittwilken
separated and added contrast conversion functions for arrays and dicts
770bcfd
@LynnSchmittwilken
fixed small bug for small colormap
d6b4867
@LynnSchmittwilken
changed function behind grating-components
edfd985
@LynnSchmittwilken
reduced use of scipy to utils
4e483ed
@LynnSchmittwilken
fixed bug in domijan2015-rings; raising error for odd ppds because st…
48c5721 
…imulus behavior is not fully robust
@LynnSchmittwilken
made draw_sine_wave seperate; added frames and circulars sine-wave an…
9d7fb21 
…d square-wave; corrected bug in circular gratings
@LynnSchmittwilken
added new frames and circular components to overview
d15d172
JorisVincent
JorisVincent approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@JorisVincent JorisVincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JorisVincent JorisVincent added this to the v1.0.0 milestone Mar 15, 2023
@JorisVincent JorisVincent merged commit 3288218 into main Mar 15, 2023
@JorisVincent JorisVincent deleted the lynn_issues branch March 15, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisVincent JorisVincent JorisVincent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LynnSchmittwilken @JorisVincent