Tomer fixes #108
Merged
Tomer fixes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate code that is related solely to the CLI application from the code that is related to the library itself (i.e. the engine). This, together with the separation of the GUI code, is done not only for the purpose of separation, but to allow us to create a useful Python library for printing with Dymo printers.
Separate code that is shared between CLI and GUI applications (i.e. the engine itself). This, together with the separation of the GUI and UI code, is done not only for the purpose of separation, but to allow us to create a useful Python library for printing with Dymo printers.
Use FontStyle and FontConfig classes. Use ConfigFile logic to read fonts section in configuration file.
|
Excellent as usual, thanks @tomers!!! When I ran it I hit some exceptions, e.g. with If you feel so motivated, it would be nice to get rid of that Are you familiar with |
|
See also tomers#3 |
|
And mypy: tomers#4 |
Better to use the more specific exception type ValueError. Also the previous `super` call was broken for me.
In practice using abstract Python iterators tends to lead to more trouble than it's worth.
|
Thank you so much @maresb ! It's really a pleasure to work with you. You are very responsive and helpful. |
|
Likewise!!! I'm very happy to have your energy and enthusiasm to move things so far forward here! The codebase is in much better shape since you came along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more improvements. Mainly separation of code, and create helper classes.