Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn dymoprint into a package #35

Merged
merged 50 commits into from
Nov 11, 2021
Merged

Turn dymoprint into a package #35

merged 50 commits into from
Nov 11, 2021

Conversation

maresb
Copy link
Collaborator

@maresb maresb commented Oct 4, 2020

I reworked dymoprint into a package on PyPI. I put the package under my account only to prevent potential squatting, and I would like to transfer ownership to someone else ASAP. Although the uploaded package currently points to my fork, I want to change it to refer to this original repository. (To be clear, I consider my own contributions minimal, and I'm not trying to claim ownership or credit; in case you don't like what I've done, I will delete the PyPI package.)

My motivation is that I'd like to be able to import dymoprint from another project and use it as a backend. It has the nice side-effect that it becomes easier to install:

pip install dymoprint

In order to achieve something sensible, I broke the monolithic dymoprint executable into several modules, putting Sebastian's original license at the top of each resulting .py. I also created a setup.py where I put myself as "maintainer", but please change that to whoever wants to maintain this.

Although I did a major restructuring of the code, I have left the original source mostly intact. Indeed, I managed to preserve the attributions in the "git blame" by performing an octopus merge.

TODO:

  • Merge PR
  • Give computerlyric(?) ownership of PyPI package
  • Put computerlyric(?) as maintainer in setup.py
  • Increment version in src/dymoprint/constants.py to 1.1.1
  • Run python setup.py sdist bdist_wheel and twine upload dist/* to upload a new version of the package pointing to this repo.

@maresb
Copy link
Collaborator Author

maresb commented Mar 22, 2021

After several months, I'm having no luck here. Development from my side continues here: https://github.com/maresb/dymoprint

@maresb maresb closed this Mar 22, 2021
@maresb maresb reopened this Nov 11, 2021
@maresb maresb merged commit 623180c into computerlyrik:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant