Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure we canonicalize manifest directory in-case it's a symlink #156

Merged
merged 1 commit into from Mar 18, 2022

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Mar 18, 2022

This is a problem because we attempt to "strip" the manifest directory as a prefix during some file.* operations and this fails when the path hasn't been resolved / canonicalized properly

Closes #146

This is a problem because we attempt to "strip" the manifest directory as a prefix during some file.* operations and this fails when the path hasn't been resolved / canonicalized properly

Closes comtrya#146
@rawkode rawkode requested a review from icepuma March 18, 2022 16:45
@codecov-commenter
Copy link

Codecov Report

Merging #156 (747a08d) into main (802ae58) will increase coverage by 3.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   48.07%   51.60%   +3.53%     
==========================================
  Files          49       49              
  Lines        1924     1804     -120     
==========================================
+ Hits          925      931       +6     
+ Misses        999      873     -126     
Impacted Files Coverage Δ
src/main.rs 0.00% <0.00%> (ø)
src/actions/directory/mod.rs 0.00% <0.00%> (ø)
src/actions/package/providers/yay.rs 0.00% <0.00%> (ø)
src/actions/package/providers/pkgin.rs 0.00% <0.00%> (ø)
src/actions/package/providers/bsdpkg.rs 0.00% <0.00%> (ø)
src/actions/package/providers/winget.rs 0.00% <0.00%> (ø)
src/actions/package/providers/homebrew.rs 0.00% <0.00%> (ø)
src/contexts/os.rs 96.42% <0.00%> (+0.13%) ⬆️
src/actions/file/copy.rs 14.06% <0.00%> (+0.42%) ⬆️
src/contexts/mod.rs 84.05% <0.00%> (+0.47%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802ae58...747a08d. Read the comment docs.

Copy link
Member

@icepuma icepuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some clippy warnings, the rest looks good!

@rawkode rawkode merged commit 5309d5d into comtrya:main Mar 18, 2022
@rawkode rawkode deleted the fix/canonicalize-manifest-dir branch March 18, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: manifest directory resolution fails when falls inside a symlink
3 participants