Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: manifest directory resolution fails when falls inside a symlink #146

Closed
rawkode opened this issue Mar 13, 2022 · 0 comments · Fixed by #156
Closed

bug: manifest directory resolution fails when falls inside a symlink #146

rawkode opened this issue Mar 13, 2022 · 0 comments · Fixed by #156
Milestone

Comments

@rawkode
Copy link
Member

rawkode commented Mar 13, 2022

We try to strip the prefix off the manifest directory (line 29 of manifest/mod) and this fails when the resolution of the path isn't canonical.

@rawkode rawkode added this to the v0.8.0 milestone Mar 13, 2022
rawkode added a commit to rawkode/comtrya that referenced this issue Mar 18, 2022
This is a problem because we attempt to "strip" the manifest directory as a prefix during some file.* operations and this fails when the path hasn't been resolved / canonicalized properly

Closes comtrya#146
rawkode added a commit that referenced this issue Mar 18, 2022
This is a problem because we attempt to "strip" the manifest directory as a prefix during some file.* operations and this fails when the path hasn't been resolved / canonicalized properly

Closes #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant