Initial support for Macports #235
Merged
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 46.26% 45.72% -0.54%
==========================================
Files 71 72 +1
Lines 2475 2504 +29
==========================================
Hits 1145 1145
- Misses 1330 1359 +29
Continue to review full report at Codecov.
|
|
Could you run |
|
You can rebase your branch. I merged my PR, so a bunch of |
icepuma
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the current behaviour?
No support for macports package manager.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
Allow installing software with macports.
What is the motivation / use case for changing the behavior?
Feature request for MacPorts support as per issue #191
Please tell us about your environment:
Version (
comtrya --version): comtrya 0.7.4Operating system: Mac Os
Other things to note for PR.
This is a feature request from @theowenyoung. Would like some input on this. Right now the implementation assume that macports is installed and it's binary is in $PATH.
Would like to provide the bootstrap functionality in a separate PR, how that is handled can be talked about in the issue.
For the reviewer
There are some clippy warnings regarding unused imports. I do intend to make use of these as I play around with the bootstrap process. I can remove them for this PR is needed.