-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Macports #235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 46.26% 45.72% -0.54%
==========================================
Files 71 72 +1
Lines 2475 2504 +29
==========================================
Hits 1145 1145
- Misses 1330 1359 +29
Continue to review full report at Codecov.
|
Could you run |
You can rebase your branch. I merged my PR, so a bunch of |
I'm submitting a
What is the current behaviour?
No support for macports package manager.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
Allow installing software with macports.
What is the motivation / use case for changing the behavior?
Feature request for MacPorts support as per issue #191
Please tell us about your environment:
Version (
comtrya --version
): comtrya 0.7.4Operating system: Mac Os
Other things to note for PR.
This is a feature request from @theowenyoung. Would like some input on this. Right now the implementation assume that macports is installed and it's binary is in $PATH.
Would like to provide the bootstrap functionality in a separate PR, how that is handled can be talked about in the issue.
For the reviewer
There are some clippy warnings regarding unused imports. I do intend to make use of these as I play around with the bootstrap process. I can remove them for this PR is needed.