Improve Plan Process

[andrew-welker]

I'm submitting a

• bug fix
• [x ] feature
• documentation addition

What is the current behaviour?

Currently, errors resulting from files not being found are not bubbled up and factored in to execution of steps

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

Missing files should be reported when necessary, and affect planning of steps

What is the motivation / use case for changing the behavior?

Better UX when files necessary for a step are missing or weren't created in a previous step

Please tell us about your environment:

Version (comtrya --version):
Operating system: Windows 11/WSL2 Ubuntu 20.04

[andrew-welker]

@icepuma As you can see, I started with updating the resolve function to have the correct signature, then updated the Action trait's plan function to have a Result<Vec<Step>,anyhow::Error> signature...which obviously has far-reaching implications. I'm guessing this is the correct route to go down, but not sure.

[icepuma]

You could use a ? instead of the .unwrap() here

[andrew-welker]

I'm thinking that since this one is a test, .unwrap() is a better option...if it's an error, it'll panic and fail the test anyway.

[codecov-commenter]

Codecov Report

Merging #243 (bdf4c1e) into main (8ce6e12) will decrease coverage by 0.01%.
The diff coverage is 14.81%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   45.65%   45.63%   -0.02%     
==========================================
  Files          72       72              
  Lines        2510     2511       +1     
==========================================
  Hits         1146     1146              
- Misses       1364     1365       +1     

Impacted Files	Coverage Δ
app/src/commands/apply.rs	0.00% <0.00%> (ø)
lib/src/actions/binary/github.rs	0.00% <0.00%> (ø)
lib/src/actions/command/run.rs	23.07% <0.00%> (ø)
lib/src/actions/directory/copy.rs	33.33% <0.00%> (ø)
lib/src/actions/directory/create.rs	53.33% <0.00%> (ø)
lib/src/actions/file/copy.rs	15.25% <0.00%> (+0.73%)	⬆️
lib/src/actions/file/download.rs	26.66% <0.00%> (ø)
lib/src/actions/git/clone.rs	0.00% <0.00%> (ø)
lib/src/actions/macos/default.rs	0.00% <0.00%> (ø)
lib/src/actions/mod.rs	20.89% <0.00%> (+0.60%)	⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[martintc]

I get a test failing in the test suite when I run it against this branch. I don't get a repro on the main branch.

test atoms::http::download::tests::it_can ... FAILED

failures:

---- atoms::http::download::tests::it_can stdout ----
thread 'atoms::http::download::tests::it_can' panicked at 'assertion failed: `(left == right)`

Diff < left / right > :

Does our github actions not run the test suite?