Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial group add support #244

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Initial group add support #244

merged 6 commits into from
Aug 23, 2022

Conversation

martintc
Copy link
Contributor

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Comtrya does not facilitate any management of groups, specifically, adding groups

What is the expected behavior?

Through a yaml file, comtrya will be able to add groups to the system

What is the motivation / use case for changing the behavior?

Base functionality for configuring production systems

Please tell us about your environment:

Version (comtrya --version): 0.7.4
Operating system: Pop_OS 22.04 LTS
Rust: 1.63.0

@martintc martintc requested a review from icepuma August 16, 2022 03:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #244 (0a6bf43) into main (d64e6f1) will decrease coverage by 0.82%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   45.63%   44.81%   -0.83%     
==========================================
  Files          72       77       +5     
  Lines        2511     2557      +46     
==========================================
  Hits         1146     1146              
- Misses       1365     1411      +46     
Impacted Files Coverage Δ
lib/src/actions/group/add.rs 0.00% <0.00%> (ø)
lib/src/actions/group/mod.rs 0.00% <0.00%> (ø)
lib/src/actions/group/providers/linux.rs 0.00% <0.00%> (ø)
lib/src/actions/group/providers/mod.rs 0.00% <0.00%> (ø)
lib/src/actions/group/providers/none.rs 0.00% <0.00%> (ø)
lib/src/actions/mod.rs 20.28% <0.00%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintc martintc requested a review from rawkode August 16, 2022 14:47
@martintc martintc linked an issue Aug 16, 2022 that may be closed by this pull request
@martintc
Copy link
Contributor Author

With PR #243, there are changes that will need to be implemented in this PR

@martintc martintc merged commit 97863bc into comtrya:main Aug 23, 2022
@martintc martintc deleted the linux-group branch September 19, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Group Management
3 participants