Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardinalities in startSource get overwritten #1156

Closed
simonvbrae opened this issue Feb 14, 2023 · 2 comments
Closed

Cardinalities in startSource get overwritten #1156

simonvbrae opened this issue Feb 14, 2023 · 2 comments

Comments

@simonvbrae
Copy link
Contributor

Issue type:

  • ➕ Feature request

Description:

On this line in the LinkedRdfSourcesAsyncRdfIterator the cardinalities in startsource are overwritten and replaced by the cardinalities in metadata.
As a result, possibly relevant cardinalities are not available in the call to the accumulation mediator on this line.

Branch: feature/adaptive-join

@github-actions
Copy link

Thanks for the suggestion!

@rubensworks rubensworks added this to Triage in Development Feb 14, 2023
rubensworks added a commit that referenced this issue Apr 6, 2023
This caused problems related to dataset-level cardinalities
that were found in the initial source being overridden without
proper accumulation with exact cardinalities from later sources

Closes #1156
Closes #1180

May be related to comunica/comunica-feature-link-traversal#102
@rubensworks
Copy link
Member

@simonvbrae Could you manually apply the changes in LinkedRdfSourcesAsyncRdfIterator.ts as seen in the linked commit?
These should also solve your problem.

rubensworks added a commit that referenced this issue Apr 12, 2023
This caused problems related to dataset-level cardinalities
that were found in the initial source being overridden without
proper accumulation with exact cardinalities from later sources

Closes #1156
Closes #1180

May be related to comunica/comunica-feature-link-traversal#102
Development automation moved this from Triage to Done May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development
  
Done
Development

No branches or pull requests

2 participants