You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
comunica disables all stack traces when process.env.NODE_ENV === 'production'. This is not something a library should do. As Error.stackTraceLimit is a superglobal affeting the whole context (browser page or node.js process), the decision of whether you want stack traces or not should be up to the application, not a library.
Quadstore intensifies the situation because it ships a bundled version of itself through npm, with the bundler configured to replace process.env.NODE_ENV === 'production' with true. However, even without that, I wouldn't want my stack traces to always go away if I have NODE_ENV set to production for other reasons.
The text was updated successfully, but these errors were encountered:
You're right. This is a leftover "hack" from back in the day that should not be here anymore.
I should probably redo the performance evaluations, as I suspect the stacktrace limits won't have a significant impact on performance anymore.
Issue type:
Description:
comunica disables all stack traces when
process.env.NODE_ENV === 'production'
. This is not something a library should do. AsError.stackTraceLimit
is a superglobal affeting the whole context (browser page or node.js process), the decision of whether you want stack traces or not should be up to the application, not a library.Enviornment:
Node.js v14, using comunica through node-quadstore v7.
Quadstore intensifies the situation because it ships a bundled version of itself through npm, with the bundler configured to replace
process.env.NODE_ENV === 'production'
withtrue
. However, even without that, I wouldn't want my stack traces to always go away if I haveNODE_ENV
set toproduction
for other reasons.The text was updated successfully, but these errors were encountered: