Fix BindingsFactory's fromBindings type
#1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement `RDF.BindingsFactory`, `fromBindings` must accept any `RDF.Bindings`. The implementation already does, but the type doesn't.
Pull Request Test Coverage Report for Build 6836209157
💛 - Coveralls |
rubensworks
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My project was reporting a type failure in
BindingsFactory.d.ts, so I dug in to investigate. It was becausefromBindings()needs to accept anyRDF.Bindings, not just ComunicaBindings.It looks like the reason that wasn't failing in Comunica itself is that
strictFunctionTypeswas off. #1233 tried to turn that back on and address various issues it was covering up. But as noted there, it wasn't quite that simple to turn on. For now, this addresses the original type issue I hit.