chore(program_v2): log stale dimension value cleanup better

con2 · Jun 15, 2024 · ac42de2 · ac42de2
1 parent fad3f3f
commit ac42de2
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/backend/program_v2/models/dimension.py b/backend/program_v2/models/dimension.py
@@ -284,10 +284,8 @@ def save_many(
 
         for dim_dto, dim_dj in zip(dimension_dtos, django_dimensions, strict=True):
             values_to_keep = [choice.slug for choice in dim_dto.choices or []]
-            num_deleted_dvs, _ = (
-                DimensionValue.objects.filter(dimension=dim_dj).exclude(slug__in=values_to_keep).delete()
-            )
-            logger.info("Deleted %s stale dimension values for dimension %s", num_deleted_dvs, dim_dj)
+            _, deleted = dim_dj.values.exclude(slug__in=values_to_keep).delete()
+            logger.info("Stale dimension value cleanup for %s deleted %s", dim_dto.slug, deleted or "nothing")
 
         if remove_others:
             dimensions_to_keep = [dim_dto.slug for dim_dto in dimension_dtos]