Support conan.cmake in exported packages #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Jan 22, 2017
| if(CMAKE_CONFIGURATION_TYPES AND NOT CMAKE_BUILD_TYPE) | ||
|
|
||
| # TODO: Better detection | ||
| if(CONAN_EXPORTED OR CONAN_COMPILER) |
There was a problem hiding this comment.
I am not sure if I'd use CONAN_COMPILER for detection, some users might be feeding it from the command line to cmake. CONAN_EXPORTED would do the task, wouldn't it? Is it necessary to set it to ON then?
There was a problem hiding this comment.
Agree, this is a temporary workaround before CONAN_EXPORTED was defined by conan, but it's supposed to work with both 0.18 and 0.19.
| content = """cmake_minimum_required(VERSION 2.8) | ||
| project(conan_wrapper CXX) | ||
|
|
||
| set(CONAN_EXPORTED ON) |
There was a problem hiding this comment.
I guess we should remember to remove this CONAN__EXPORTED ON line, when the conan codebase already sets it automatically.
There was a problem hiding this comment.
That's true, it's not needed from the next conan release.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10.