Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeDeps should be defined in conanfile #564

Closed
wants to merge 1 commit into from
Closed

CMakeDeps should be defined in conanfile #564

wants to merge 1 commit into from

Conversation

memsharded
Copy link
Member

Close #540

The CMakeDeps in command line will be conflicting with other CMakeDeps declarations in conanfile files, which might be necessary for conanfile creating packages (that need to be run without cmake-conan integration later)

@memsharded memsharded added this to the develop2 milestone Sep 17, 2023
@memsharded memsharded mentioned this pull request Sep 17, 2023
Open
@memsharded memsharded closed this Sep 19, 2023
@memsharded
Copy link
Member Author

Closed, @jcar87 will do a better approach, that solves #540 without necessarily breaking existing users without CMakeDeps in their conanfile.txt

@memsharded memsharded deleted the fix/cmakedeps_in_conanfile branch September 19, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
develop2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @AbrilRBS