Skip to content

Commit

Permalink
(#22507) [docs] Update bump PR review rule
Browse files Browse the repository at this point in the history
* Update bump PR review rule

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update rule description for bump prs

Co-authored-by: Daniel <danimanzaneque@gmail.com>

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
  • Loading branch information
uilianries and danimtb committed Jan 25, 2024
1 parent d3cf4dd commit 1664055
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions docs/review_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,8 @@ At least 2 approving reviews are required, and at least one of them has to be fr
So, it might be 1 official + 1 community, or 2 official, but it couldn't be just 2 community reviews.
Approvals are only counted if they are associated with the latest commit in the PR, while "Change requested" ones (from the Conan team) will persist even if there are new commits. Don't hesitate to dismiss old reviews if the issues have already been addressed.

> **Note** Pull requests labelled as [`Bump version`](https://github.com/conan-io/conan-center-index/pulls?q=is%3Aopen+is%3Apr+label%3A%22Bump+version%22)
> or [`Bump dependencies`](https://github.com/conan-io/conan-center-index/pulls?q=is%3Aopen+is%3Apr+label%3A%22Bump+dependencies%22+) are merged by
> the bot without requiring any approval.
Pull requests labelled as [`Bump version`](https://github.com/conan-io/conan-center-index/pulls?q=is%3Aopen+is%3Apr+label%3A%22Bump+version%22)
or [`Bump dependencies`](https://github.com/conan-io/conan-center-index/pulls?q=is%3Aopen+is%3Apr+label%3A%22Bump+dependencies%22+) require **just 1 approving review from an official reviewer**. Community reviewers are not required but are still welcome.

### Reviews from others

Expand Down

0 comments on commit 1664055

Please sign in to comment.