[package] crashpad/cci.20210507: Missing symbols for 'crashpad::CrashReportDatabase'

[helmesjo]

Related to #5511

This symbol should be in client.lib, so not sure what went wrong in the recipe. Wrong linking order? Bug in the library?

Package and Environment Details (include every applicable attribute)

• Package Name/Version: crashpad/cci.20210507
• Operating System+version: Windows 10
• Compiler+version: Visual Studio 2019 (16.9.1)
• Conan version: conan 1.34.1
• Python version: Python 3.7.9

Conan profile (output of conan profile show default or conan profile show <profile> if custom profile is in use)

Configuration:
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug/Release
compiler=Visual Studio
compiler.runtime=MTd/MT
compiler.version=16
os=Windows
os_build=Windows

Steps to reproduce (Include if Applicable)

Add the following line to the recipe example:
auto database = crashpad::CrashReportDatabase::Initialize(reportsPath)

Logs (Include/Attach if Applicable)

Click to expand log

error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class crashpad::CrashReportDatabase,struct std::default_delete<class crashpad::CrashReportDatabase> > __cdecl crashpad::CrashReportDatabase::Initialize(class base::FilePath const &)" (?Initialize@CrashReportDatabase@crashpad@@SA?AV?$unique_ptr@VCrashReportDatabase@crashpad@@U?$default_delete@VCrashReportDatabase@crashpad@@@std@@@std@@AEBVFilePath@base@@@Z)

[madebr]

Adding:

#include "client/crash_report_database.h"

and

   auto database = crashpad::CrashReportDatabase::Initialize(base::FilePath("/tmp/some_path"));

seems to work on Linux gcc-11.

I haven't tested yet on msvc.

[helmesjo]

@madebr
Doing the same changes you mentioned above (but just passing the db var as input to creator function) and running:
conan create all crashpad/cci.20210507@test/test -s compiler="Visual Studio" -s compiler.version=16 -s compiler.runtime=MT

I get the same error as in the description:

test_package.obj : error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class crashpad::CrashReportDatabase,struct std::default
_delete<class crashpad::CrashReportDatabase> > __cdecl crashpad::CrashReportDatabase::Initialize(class base::FilePath const &)" (?Initialize@CrashReportDa
tabase@crashpad@@SA?AV?$unique_ptr@VCrashReportDatabase@crashpad@@U?$default_delete@VCrashReportDatabase@crashpad@@@std@@@std@@AEBVFilePath@base@@@Z) refe
renced in function "bool __cdecl startCrashpad(class base::FilePath const &,class base::FilePath const &)" (?startCrashpad@@YA_NAEBVFilePath@base@@0@Z) [C
:\repos\conan-center-index\recipes\crashpad\all\test_package\build\8acfa7f6642e42a872d24f9595f71a4c0d0a89de\test_package.vcxproj]
C:\repos\conan-center-index\recipes\crashpad\all\test_package\build\8acfa7f6642e42a872d24f9595f71a4c0d0a89de\bin\test_package.exe : fatal error LNK1120: 1
 unresolved externals [C:\repos\conan-center-index\recipes\crashpad\all\test_package\build\8acfa7f6642e42a872d24f9595f71a4c0d0a89de\test_package.vcxproj]
ERROR: crashpad/cci.20210507@test/test (test package): Error in build() method, line 12
        cmake.build()
        ConanException: Error 1 while executing cmake --build C:\repos\conan-center-index\recipes\crashpad\all\test_package\build\8acfa7f6642e42a872d24f9595f71a4c0d0a89de --config Release -- /m:20 /verbosity:minimal