Crashpad recipe #5511

madebr · 2021-05-10T21:11:15Z

Specify library name and version: crashpad/some-git-hash

This packages crashpad.
It also embeds mini_chromium, of which the library + build system is used.

Chromium's mini_chromium project does not have a self-containing gn build system.

Also, Windows is (currently) not supported by this recipe because it requires python 2.x.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

… http_transport=socket

ghost · 2021-05-10T21:11:44Z

I detected other pull requests that are modifying crashpad/all recipe:

Add crashpad [Draft] [Help Needed] #5419

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

madebr · 2021-05-10T22:46:59Z

@jgsogo
c3i is telling me to not raise ConanInvalidConfiguration from build(), but I'm not doing that at all (only in validate).
Can you please look at the error in #5511 (comment)?

Thanks!

ericriff · 2021-05-10T23:35:18Z

This recipe needs components, otherwise it won't be consumable by sentry-native.
https://github.com/getsentry/sentry-native/blob/master/CMakeLists.txt#L396

madebr · 2021-05-11T00:27:59Z

This recipe needs components, otherwise it won't be consumable by sentry-native.
https://github.com/getsentry/sentry-native/blob/master/CMakeLists.txt#L396

Thanks for noticing.
Although the components are sentry-crashpad specific, I think there is great value in having them here too.
I will add them in the next commits.

jgsogo · 2021-05-11T06:49:43Z

c3i is telling me to not raise ConanInvalidConfiguration from build(), but I'm not doing that at all (only in validate).
Can you please look at the error in #5511 (comment)?

Thanks!

Found... It surprises me it is the first time this happens. The problem comes from the gn package, it requires C++17. When this package is going to be built, the build-requires are evaluated and gn raises a ConanInvalidConfiguration for some configurations (it is build time for crashpad).

But the binary gn is already available, so this check is not applicable at this time.

(I keep thinking about this issue and solution)

jgsogo · 2021-05-11T14:34:21Z

After approaching the issue in many different ways, I think that the best we can do is to allow these ConanInvalidConfiguration from the build step. They are not desired, but if we consider them an error, some PRs like this one will be blocked unless we fix a couple of issues in Conan client.

This is my proposal (I've already submitted a PR to the library):

short term: this will no longer be an error, instead we will show a warning so the author/reviewer can have a look to it and decide if this is something that needs to be fixed or it is unrelated to this PR.
long term: there are a couple of issues/features for Conan client:
- the command conan info <reference> --build should provide all the information from libraries and build-requires, it should execute the function validate() as well to return if the build-requires can be computed for the given configuration.
- packageID (and compatible packages) must be checked before raising any exception from validate() if the recipe is not going to be built.

Hopefully it will be approved, merged, and deployed soon. If we go for a different implementation I will let you know.

madebr · 2021-05-11T16:49:15Z

Thanks for the quick feedback!
I'm glad to hear there's a short-term fix and path to a fix long term.

jgsogo · 2021-05-18T10:05:57Z

recipes/crashpad/all/conanfile.py

+                # FIXME: is this true?
+                self.output.warn("crashpad needs a shared libcurl library")
+        if self.settings.os == "Windows":
+            raise ConanInvalidConfiguration("Windows is not (yet) supported by this recipe because the build system requires python 2.x which is not (yet) available on CCI.")


Maybe it is better to just patch the sources? Recipe for cpython is being hard.

Is this really still the case? depot_tools in recent versions should work fine with python 3.8, which AFAIK is the dependency that had the python issues.

It works on Python 3.9.5 on Linux (works on my machine).
But an error is thrown when building on Windows.
Maybe it can be patched..

qjgn · 2021-05-21T09:00:36Z

recipes/crashpad/all/conanfile.py

+
+        self.copy("*.a", src=os.path.join(self._source_subfolder, "out", "Default"), dst="lib", keep_path=False)
+        self.copy("crashpad_handler", src=os.path.join(self._source_subfolder, "out", "Default"), dst="bin", keep_path=False)
+        self.copy("crashpad_handler.exe", src=os.path.join(self._source_subfolder, "out", "Default"), dst="bin", keep_path=False)


On Windows there seems to be two executables provided. (missing .com)

https://chromium.googlesource.com/crashpad/crashpad/+/master/doc/overview_design.md

On Windows, this executable is built by default as a Windows GUI app, so no console will appear in normal usage. This is the version that will typically be used. A second copy is also made with a .com extension, rather than .exe. In this second copy, the PE header is modified to indicate that it’s a console app. This is useful because the .com is found in the path before the .exe, so when run normally from a shell using only the basename (without an explicit .com or .exe extension), the .com console version will be chosen, and so stdio will be hooked up as expected to the parent console so that logging output will be visible.

Fixed in eb7a82a but untested

I added it. It's called crashpad_handler_com.com.

How come it's called crashpad_handler_com.com instead of just crashpad_handler.com as according to the documentation?

recipes/crashpad/all/conanfile.py

prince-chrismc

Couple of comments quickly going over

recipes/crashpad/all/conanfile.py

recipes/crashpad/all/test_package/conanfile.py

conan-center-bot · 2021-05-22T06:44:00Z

All green in build 21 (63a61f8ffd58511a3604843f92deaee69a645c84):

crashpad/cci.20210507@:
All packages built successfully! (All logs)

prince-chrismc · 2021-05-23T12:42:17Z

Awesome work!

* sentry: add recipe (WIP) * switch to github fork * crashpad: only require libcurl when curl is needed * crashpad: add windows system libraries * crashpad: add explicit zlib * crashpad: add tls option if http_transport=socket + add tls option if http_transport=socket * crashpad: fixes * crashpad: various * crashpad: no Windows for you * crashpad: print found files in library folder (DEBUG) * crashpad: handle libs per component * crashpad: needs CoreFoundation framework * crashpad: cosmetup changes * crashpad: apple thingies * crashpad: fixie * crashpad: fixie^2 * crashpad: add ninja to build_requires * crashpad: add components + bump git hash * crashpad: drop verbose ninja build * crashpad: crashpad requires c++14 (pass through CMake target) * crashpad: add provides attribute to recipe * crashpad: add mini_chromium provides + add bin to PATH env * crashpad: build crash_handler.com on Windows * crashpad: use patches + msvc + win_helper.py -> py3 * crashpad: remove unused patch * crashpad: update comments * crashpad: check compiler versions in validate()

since conan-io/conan-center-index#5511 is merged

madebr added 9 commits May 10, 2021 22:57

sentry: add recipe (WIP)

76393f9

switch to github fork

72e829c

crashpad: only require libcurl when curl is needed

c3c5344

crashpad: add windows system libraries

97da449

crashpad: add explicit zlib

86211a0

crashpad: add tls option if http_transport=socket + add tls option if…

9f80e66

… http_transport=socket

crashpad: fixes

c33efe3

crashpad: various

df147bb

crashpad: no Windows for you

9820f33

ghost mentioned this pull request May 10, 2021

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request May 10, 2021

Add crashpad [Draft] [Help Needed] #5419

Closed

4 tasks

github-actions bot mentioned this pull request May 10, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label May 10, 2021

crashpad: print found files in library folder (DEBUG)

b5a2615

This comment has been minimized.

Sign in to view

crashpad: handle libs per component

d23d8e2

This comment has been minimized.

Sign in to view

crashpad: needs CoreFoundation framework

1fadeea

This comment has been minimized.

Sign in to view

crashpad: cosmetup changes

d2d39f8

This comment has been minimized.

Sign in to view

jgsogo added the blocked Affected by an external issue and waiting until it is solved label May 11, 2021

jgsogo reviewed May 18, 2021

View reviewed changes

qjgn reviewed May 21, 2021

View reviewed changes

crashpad: build crash_handler.com on Windows

eb7a82a

This comment has been minimized.

Sign in to view

ericriff previously approved these changes May 21, 2021

View reviewed changes

recipes/crashpad/all/conanfile.py Show resolved Hide resolved

prince-chrismc reviewed May 21, 2021

View reviewed changes

recipes/crashpad/all/conanfile.py Outdated Show resolved Hide resolved

recipes/crashpad/all/conanfile.py Show resolved Hide resolved

recipes/crashpad/all/test_package/conanfile.py Show resolved Hide resolved

crashpad: use patches + msvc + win_helper.py -> py3

38c4462

madebr dismissed ericriff’s stale review via 38c4462 May 21, 2021 22:15

crashpad: remove unused patch

d2859a5

This comment has been minimized.

Sign in to view

crashpad: update comments

a1f3795

This comment has been minimized.

Sign in to view

crashpad: check compiler versions in validate()

63a61f8

This comment has been minimized.

Sign in to view

conan-center-bot added Failed Unexpected Error labels May 21, 2021

madebr closed this May 22, 2021

madebr reopened this May 22, 2021

conan-center-bot removed Unexpected Error Failed labels May 22, 2021

prince-chrismc approved these changes May 23, 2021

View reviewed changes

jgsogo approved these changes May 24, 2021

View reviewed changes

SSE4 approved these changes May 24, 2021

View reviewed changes

conan-center-bot merged commit 2e42473 into conan-io:master May 24, 2021

madebr deleted the crashpad_recipe branch May 24, 2021 08:43

helmesjo mentioned this pull request May 24, 2021

[package] crashpad/cci.20210507: Missing symbols for 'crashpad::CrashReportDatabase' #5618

Closed

ericLemanissier added a commit to bincrafters/community that referenced this pull request Oct 18, 2021

disable crashpad

4f98461

since conan-io/conan-center-index#5511 is merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crashpad recipe #5511

Crashpad recipe #5511

madebr commented May 10, 2021

ghost commented May 10, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

madebr commented May 10, 2021

ericriff commented May 10, 2021

madebr commented May 11, 2021 •

edited

Loading

jgsogo commented May 11, 2021 •

edited

Loading

jgsogo commented May 11, 2021

madebr commented May 11, 2021

jgsogo May 18, 2021

helmesjo May 21, 2021

madebr May 21, 2021

qjgn May 21, 2021

madebr May 21, 2021 •

edited

Loading

madebr May 21, 2021

helmesjo May 24, 2021

This comment has been minimized.

prince-chrismc left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 22, 2021

prince-chrismc commented May 23, 2021

Crashpad recipe #5511

Crashpad recipe #5511

Conversation

madebr commented May 10, 2021

ghost commented May 10, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

madebr commented May 10, 2021

ericriff commented May 10, 2021

madebr commented May 11, 2021 • edited Loading

jgsogo commented May 11, 2021 • edited Loading

jgsogo commented May 11, 2021

madebr commented May 11, 2021

jgsogo May 18, 2021

Choose a reason for hiding this comment

helmesjo May 21, 2021

Choose a reason for hiding this comment

madebr May 21, 2021

Choose a reason for hiding this comment

qjgn May 21, 2021

Choose a reason for hiding this comment

madebr May 21, 2021 • edited Loading

Choose a reason for hiding this comment

madebr May 21, 2021

Choose a reason for hiding this comment

helmesjo May 24, 2021

Choose a reason for hiding this comment

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 22, 2021

prince-chrismc commented May 23, 2021

madebr commented May 11, 2021 •

edited

Loading

jgsogo commented May 11, 2021 •

edited

Loading

madebr May 21, 2021 •

edited

Loading