Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taocpp-taopq: bump libpq + modernize #10618

Merged
merged 2 commits into from
May 8, 2022
Merged

taocpp-taopq: bump libpq + modernize #10618

merged 2 commits into from
May 8, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented May 4, 2022

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@prince-chrismc prince-chrismc mentioned this pull request May 4, 2022
Open
@conan-center-bot
Copy link
Collaborator

All green in build 1 (8854b836dc86ceb6e4abd436c91d8b18c9696558):

  • taocpp-taopq/cci.20210727@:
    All packages built successfully! (All logs)

  • taocpp-taopq/cci.20200222@:
    All packages built successfully! (All logs)

toge
toge reviewed May 5, 2022
View reviewed changes
recipes/taocpp-taopq/all/test_package/CMakeLists.txt
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question.
Is there any reason to upgrade the minimum required version of cmake to 3.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++17

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. Thank you.

@conan-center-bot conan-center-bot merged commit e46a9b0 into conan-io:master May 8, 2022
@SpaceIm SpaceIm deleted the taocpp-taopq-modernize branch May 8, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toge toge toge approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SpaceIm @conan-center-bot @toge @uilianries