Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cppunit to be compiled without msys2 #11030

Closed
wants to merge 1 commit into from
Closed

Allow cppunit to be compiled without msys2 #11030

wants to merge 1 commit into from

Conversation

wbehrens-on-gh
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@wbehrens-on-gh wbehrens-on-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current cppunit recipe only uses autotools and thus requires msys2 as a dependency to build on Windows. I'm not sure about anyone else but I can never get the msys2 recipe to work correctly so this pr make cppunit compile with visual studio on windows to remove it's dependency on msys2

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (de2174362b474774c0c2e8c128c47b1d1c353ee8):

  • cppunit/1.15.1@:
    CI failed to create some packages (All logs)

    Logs for packageID 970e773c5651dc2560f86200a4ea56c23f568ff9:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=15
    os=Windows
    [options]
    cppunit:shared=True
    
    [...]
    -- Conan: Adjusting language standard
    -- Configuring done
    -- Generating done
    -- Build files have been written to: C:/J/w/prod/BuildSingleReference@2/conan-center-index/recipes/cppunit/all/test_package/build/e4a1d58d289e2679035f03415b89861319828456
    
    ----Running------
    > cmake --build C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456 --config Release -- /m:8 /verbosity:minimal
    -----------------
    Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
    Copyright (C) Microsoft Corporation. All rights reserved.
    
      Checking Build System
      Building Custom Rule C:/J/w/prod/BuildSingleReference@2/conan-center-index/recipes/cppunit/all/test_package/CMakeLists.txt
      test_package.cpp
    C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/CompilerOutputter.h(138): warning C4251: 'CppUnit::CompilerOutputter::m_locationFormat': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'CppUnit::CompilerOutputter' [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\test_package.vcxproj]
      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring(4373): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
    C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/SourceLine.h(56): warning C4251: 'CppUnit::SourceLine::m_fileName': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'CppUnit::SourceLine' [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\test_package.vcxproj]
      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring(4373): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
    C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/Exception.h(20): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'CppUnit::Exception' [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\test_package.vcxproj]
      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\vcruntime_exception.h(44): note: see declaration of 'std::exception'
      C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/Exception.h(19): note: see declaration of 'CppUnit::Exception'
    C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/Exception.h(82): warning C4251: 'CppUnit::Exception::m_whatMessage': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'CppUnit::Exception' [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\test_package.vcxproj]
      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring(4373): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
    C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/TestCase.h(50): warning C4251: 'CppUnit::TestCase::m_name': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'CppUnit::TestCase' [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\test_package.vcxproj]
      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring(4373): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
    C:\J\w\prod\BuildSingleReference@2\.conan\data\cppunit\1.15.1\_\_\package\970e773c5651dc2560f86200a4ea56c23f568ff9\include\cppunit/extensions/TestNamer.h(74): warning C4251: 'CppUnit::TestNamer::m_fixtureName': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'CppUnit::TestNamer' [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\test_package.vcxproj]
      C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xstring(4373): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
      test_package.vcxproj -> C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\cppunit\all\test_package\build\e4a1d58d289e2679035f03415b89861319828456\bin\test_package.exe
      Building Custom Rule C:/J/w/prod/BuildSingleReference@2/conan-center-index/recipes/cppunit/all/test_package/CMakeLists.txt
    cppunit/1.15.1 (test package): Running test()
    
    ----Running------
    > bin\test_package
    -----------------
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    ERROR: cppunit/1.15.1 (test package): Error in test() method, line 17
    	self.run(bin_path, run_environment=True)
    	ConanException: Error 3221225781 while executing bin\test_package
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@SSE4
Copy link
Contributor

SSE4 commented Jul 1, 2022

3221225781 is STATUS_DLL_NOT_FOUND

@stale
Copy link

stale bot commented Jul 31, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2022
@stale
Copy link

stale bot commented Sep 8, 2022

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants