Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensubdiv: Add recipe #11450

Merged
merged 16 commits into from
Aug 12, 2022
Merged

Conversation

Latios96
Copy link
Contributor

Specify library name and version: opensubdiv/3.4.4


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 42a07ce
opensubdiv/3.4.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libosdCPU.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

…ensubdiv:shared=True and compiler.libcxx == "libc++"
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Latios96 Latios96 closed this Jul 3, 2022
@Latios96 Latios96 reopened this Jul 3, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Hooks produced the following warnings for commit aec2e14
opensubdiv/3.4.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libosdCPU.so' links to system library 'm' but it is not in cpp_info.system_libs.

@Latios96 Latios96 requested a review from uilianries July 12, 2022 16:56
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question since I am not familiar with this project over all this looks really good!

recipes/opensubdiv/all/conanfile.py Outdated Show resolved Hide resolved
recipes/opensubdiv/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 650433f
opensubdiv/3.4.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libosdCPU.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 94e2691
opensubdiv/3.4.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libosdCPU.so' links to system library 'm' but it is not in cpp_info.system_libs.

@Latios96
Copy link
Contributor Author

@uilianries @prince-chrismc thanks for your feedback! I'm sorry, I was a bit busy the last two weeks, but now I finally managed to address your comments

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update tools usage due Conan v2 linter, which help us to keep compatibility with next Conan major release.

recipes/opensubdiv/all/conanfile.py Outdated Show resolved Hide resolved
recipes/opensubdiv/all/conanfile.py Outdated Show resolved Hide resolved
recipes/opensubdiv/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 15 (25ca40a0d284f925eda09f8f53ac32da1d2431ab):

  • opensubdiv/3.4.4@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11450/recipes/opensubdiv/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11450/recipes/opensubdiv/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11450/recipes/opensubdiv/all/conanfile.py", line 6, in <module>
        from conans import CMake, tools
    ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 25ca40a
opensubdiv/3.4.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libosdCPU.so' links to system library 'm' but it is not in cpp_info.system_libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants