Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement mold/1.3.1 recipe #11536

Merged
merged 46 commits into from
Jul 31, 2022

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Jul 4, 2022

Specify library name and version: mold/1.3.1

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

closes #11522

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@AndreyMlashkin AndreyMlashkin marked this pull request as draft July 4, 2022 16:41
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@friendlyanon as you have implemented several make-file projects:
How can I forward CONAN_INCLUDE_DIRS_ZLIB variable to a makefile? My approach seems not to work, as variable is not substitured

@uilianries
Copy link
Member

@AndreyMlashkin it seems like it only will work with libstdc++11

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@uilianries @ericLemanissier @jgsogo @toge, please also review :)

recipes/mold/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mold/all/conanfile.py Show resolved Hide resolved
recipes/mold/all/conanfile.py Outdated Show resolved Hide resolved
AndreyMlashkin and others added 2 commits July 29, 2022 10:29
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 46 (a3151ccd53a3b896fa0b7eb4ec42f09d96784f50):

  • mold/1.3.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11536/recipes/mold/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11536/recipes/mold/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11536/recipes/mold/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, AutoToolsBuildEnvironment
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit c662616 into conan-io:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] mold/1.3.1
8 participants