-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt/6.x.x: Added missing imageformats plugins #11551
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution. It looks like these 3 plugins are actually part of qtbase and not qtimageformats : qtbase
Can you please move their declaration outside of this if self.options.get_safe("qtimageformats")
? Also, please add the jpeg package to QJpegPlugin
's requires
(I think it can be removed from qtgui'srequires
in
conan-center-index/recipes/qt/6.x.x/conanfile.py
Lines 991 to 994 in 8e79e26
if self.options.with_libjpeg == "libjpeg-turbo": | |
gui_reqs.append("libjpeg-turbo::libjpeg-turbo") | |
if self.options.with_libjpeg == "libjpeg": | |
gui_reqs.append("libjpeg::libjpeg") |
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! thank you very much
CI seems stuck.... You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁 |
This comment has been minimized.
This comment has been minimized.
#11828 was merged should be good to try again |
All green in build 7 (
|
Hooks produced the following warnings for commit 0d241b1qt/6.2.4
qt/6.1.3
qt/6.3.1
qt/6.0.4
qt/6.3.0
|
Specify library name and version: qt/6.x.x
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!