Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperscan build_chimera option #11576

Merged
merged 6 commits into from
Jul 31, 2022

Conversation

syoliver
Copy link
Contributor

@syoliver syoliver commented Jul 6, 2022

Specify library name and version: hyperscan/5.4.0

Fix build_chimera option
Add components for cmake_find_package and cmake_find_package_multi generators


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

…cture only + chimera cannot be build as a static library
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

jwillikers
jwillikers previously approved these changes Jul 13, 2022
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit dd9d5b9
hyperscan/5.4.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libhs.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries
uilianries previously approved these changes Jul 27, 2022
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jul 28, 2022
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about new properties, otherwise it looks good

recipes/hyperscan/all/conanfile.py Show resolved Hide resolved
recipes/hyperscan/all/conanfile.py Show resolved Hide resolved
recipes/hyperscan/all/conanfile.py Show resolved Hide resolved
recipes/hyperscan/all/conanfile.py Show resolved Hide resolved
recipes/hyperscan/all/conanfile.py Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 11 (1b85b0631495b29bdbc0d8f910e9c638e731c86a):

  • hyperscan/5.4.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11576/recipes/hyperscan/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11576/recipes/hyperscan/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11576/recipes/hyperscan/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@conan-center-bot conan-center-bot merged commit f474eb6 into conan-io:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants