Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to delete diligent-tools patches #11819

Merged

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Jul 20, 2022

Specify library name and version: diligent-tools/all

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ericLemanissierBot
Copy link

ericLemanissierBot commented Jul 20, 2022

I detected other pull requests that are modifying diligent-tools/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@jgsogo @prince-chrismc I have a challange here.

diligent-tools tries to install some python package via pip:
https://github.com/DiligentGraphics/DiligentTools/blob/e604522a83d2186f9df823515751c8034b7fb7e8/RenderStateNotation/CMakeLists.txt#L26

As I understand, it it forbidden in conan CI. At least, previous builds failed because of it.
As I see, they are required in some other python build scripts.

Is it possible to get/import these packages via conanfile?

@uilianries
Copy link
Member

uilianries commented Jul 25, 2022

@AndreyMlashkin No way. If libclang need to be installed as mandatory dependency, I would say to take a look on llvm-core package, otherwise, it will need a new package.

Pip will install other packages, but Conan will not be able to manage it, it will affect the package id, but we have no hint about it, it will always the same, but pip can change anything and we will not track.

In the very very past, I did a workaround involving Conan + pip, using pip.main(). But still, is not something to be used here. Sorry.

@AndreyMlashkin
Copy link
Contributor Author

I will remove adding of a new version for now

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 11 (108537dff6a1559a58ace8942b7488fd1ce87087):

  • diligent-tools/cci.20211009@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11819/recipes/diligent-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11819/recipes/diligent-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11819/recipes/diligent-tools/all/conanfile.py", line 2, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • diligent-tools/2.5.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11819/recipes/diligent-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11819/recipes/diligent-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11819/recipes/diligent-tools/all/conanfile.py", line 2, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@AndreyMlashkin
Copy link
Contributor Author

@uilianries @SSE4 @ericLemanissier @prince-chrismc
please approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants