New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librdkafka: add version 1.9.1 and remove older versions #11882

Merged

conan-center-bot merged 3 commits into conan-io:master from toge:librdkafka-1.9.1

Jul 26, 2022

Contributor

toge commented Jul 23, 2022

Specify library name and version: librdkafka/*

add version 1.9.1
- add curl options because librdkafka >=1.9.0 requires libcurl when WITH_CURL is ON.
remove version 1.3.0, 1.4.0, 1.5.2
- remove patches of these versions too.
update dependencies
sort versions
use conan.tools.build.cross_building

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.


          librdkafka: add version 1.9.1 and remove older versions

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label

This was referenced Jul 23, 2022

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Open


          set LZ4_FOUND ON

fbf71aa

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label

Member

uilianries commented Jul 25, 2022

@toge probably the project is using CMake with find_package, but without CONFIG, so the generator cmake_find_package_multi will not work on that case.

Contributor Author

toge commented Jul 25, 2022

@uilianries
I totally forgot it.
I will try to fix.
Thank you a lot!


          add CONFIG

783b2ce

conan-center-bot removed the Failed label

Collaborator

conan-center-bot commented Jul 25, 2022

All green in build 3 (783b2cedc222fd5913a3736b60db33d84784f175):

librdkafka/1.8.2@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

librdkafka/1.8.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

librdkafka/1.7.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

librdkafka/1.6.1@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

librdkafka/1.6.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

librdkafka/1.5.3@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

librdkafka/1.9.1@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11882/recipes/librdkafka/all/conanfile.py", line 1, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

uilianries approved these changes

View reviewed changes

Member

uilianries left a comment

Thank you @toge !!!

prince-chrismc approved these changes

View reviewed changes

prince-chrismc reviewed

View reviewed changes

recipes/librdkafka/all/conanfile.py

Comment on lines 35 to +37

                       "ssl": False,
                       "sasl": False,
+                      "curl": False,

Contributor

prince-chrismc Jul 26, 2022

too bad these dont follow the convention/rule in the docs

conan-center-bot merged commit 169c3db into conan-io:master

SpaceIm reviewed

View reviewed changes

recipes/librdkafka/all/conanfile.py

                   }
-                  generators = "cmake", "cmake_find_package", "pkg_config"
+                  generators = "cmake", "cmake_find_package_multi", "pkg_config"

Contributor

SpaceIm Aug 3, 2022 •

edited

Please keep cmake_find_package generator as well. You never want to have cmake_find_package_multi without cmake_find_package when there are dependencies part of https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules

SpaceIm reviewed

View reviewed changes

recipes/librdkafka/all/patches/0002-Change-library-targets-and-result-variables-1-9-1.patch

+              -  target_link_libraries(rdkafka PRIVATE ${ZSTD_LIBRARY})
+              -  target_include_directories(rdkafka PRIVATE ${ZSTD_INCLUDE_DIR})
+              -  message(STATUS "Found ZSTD: ${ZSTD_LIBRARY}")
+              +  target_link_libraries(rdkafka PRIVATE zstd::zstd)

Contributor

SpaceIm Aug 3, 2022

will break with CMakeDeps

Contributor

SpaceIm commented Aug 3, 2022

#12022 addresses my review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment