-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serd: add version 0.30.14 #11897
serd: add version 0.30.14 #11897
Conversation
This comment has been minimized.
This comment has been minimized.
I would need help with reading the failed CI runs:
A general question:
A closing comment on 0.30.12 vs 0.30.14. In 0.30.12, we disabled the build for VS and ARM MacOS because it was hard to figure out how to do it right with the customized WAF build system shipped with serd. With serd using meson now, I think it should be easy. |
@bigerl Thank you for contribution!
It's not mandatory to pass/merge your PR, but it's well recommended. In some months, Conan 2.0 will be available and we will need to migrate all recipes, include this one. More information: https://docs.conan.io/en/latest/conan_v2.html In short answer: Yes, please, replace it by https://docs.conan.io/en/latest/reference/conanfile/tools/build.html#conan-tools-build-cross-building
Once a job fails, others are canceled to save CI time. It's a regular process are Conan Center Index needs to generated more than 100 packages for each new pull request.
It's some Meson behavior with Serd project. I would say to read the Meson file provided by Serd and find someway to disable that validation.
Yes, CCI has around 30 recipes using Meson. Still, cross-building is hard. I would suggest taking a look on https://github.com/conan-io/conan-center-index/search?q=Meson&type=code and check what other recipes are doing. |
a modern alternatiive is can_run |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All green in build 13 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Specify library name and version: serd/0.30.14
The build system changed to meson in this release. So a more thorough review is required.