Fix folly CXX_STD #11938

Hopobcn · 2022-07-27T11:34:52Z

Specify library name and version: folly/all

Fixes [bug] folly incorrect CXX_STD when self.settings.compiler.cppstd is set #11937
updates fmt dependency to latest 7.x.x supported in CCI (7.1.3)
Migrate test_package to comply with v2 linter

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

Hopobcn · 2022-07-27T17:18:05Z

recipes/folly/all/conanfile.py:144: [E1101(no-member), FollyConan._configure_cmake] Module 'conans.tools' has no 'cross_building' member

Mmm even if the recipe doesn't use cross_building this linter check is failing. This means now it is forbidden to include conans.tools ?

CC: @SSE4

Hopobcn · 2022-07-27T22:09:27Z

I'm not sure c3i bot that parses test_package is working well. Waiting for SSE4 feedback but probably I will rollback 6a33810

SSE4 · 2022-07-28T06:49:49Z

I'm not sure c3i bot that parses test_package is working well. Waiting for SSE4 feedback but probably I will rollback 6a33810

it raies for this line (not for test_package): https://github.com/conan-io/conan-center-index/pull/11938/files#diff-c76b59bc54e55f5a4d20622555a9653f5345015c0c85716862cdab5139eb4dc6R144
P.S. no need to revert, it doesn't block the merge

prince-chrismc · 2022-07-31T03:30:50Z

No obvious reason why it failed 🤔

uilianries · 2022-08-01T09:28:48Z

There is a conflict version: WARN: libevent/2.1.12: requirement openssl/1.1.1m overridden by folly/2019.10.21.00 to openssl/1.1.1q

uilianries · 2022-08-01T09:54:05Z

It seems be a runtime error when running the test_package.

prince-chrismc · 2022-08-02T16:02:13Z

libunwind/1.5.0: Already installed!
folly/2019.10.21.00: Already installed!
folly/2019.10.21.00 (test package): Generator 'CMakeDeps' calling 'generate()'
folly/2019.10.21.00 (test package): Generator 'VirtualRunEnv' calling 'generate()'
folly/2019.10.21.00 (test package): Generator txt created conanbuildinfo.txt
folly/2019.10.21.00 (test package): Calling generate()
folly/2019.10.21.00 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
folly/2019.10.21.00 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: folly/2019.10.21.00 (test package): Error in generate() method, line 18
	tc.variables["FOLLY_VERSION"] = self.dependencies["fmt"].ref.version
	KeyError: {'ref': fmt/unknown@unknown/unknown, 'build': False, 'direct': True, 'test': False, 'visible': True}
********************************************************************************
conan test conan-center-index/recipes/folly/all/test_v1_package/conanfile.py folly/2019.10.21.00@#c34697b5055a561723884d696ec459f8

recipes/folly/all/test_package/conanfile.py

- Use tools.cppstd_flag when self.settings.compiler.cppstd is defined to correctly define CXX_STD - Update openssl dependency to 1.1.1q - Update fmt dependency to 7.1.3 - Comply with linter v2 * migrate test_package * Replace cross_building by can_run * Replace conans.tools.Version by conan.tools.scm.Version * Replace conans.tools.get fro conan.tools.files.get * conans.tools.rmdir for conan.tools.files.rmdir

conan-center-bot · 2022-08-03T11:59:30Z

All green in build 8 (2cee9665456cc261abe00c6336c98608bdb3d709):

folly/2022.01.31.00@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

folly/2020.08.10.00@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

folly/2019.10.21.00@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11938/recipes/folly/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Jul 27, 2022

github-actions bot mentioned this pull request Jul 27, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 27, 2022

conan-center-bot removed the Failed label Jul 28, 2022

Hopobcn mentioned this pull request Jul 28, 2022

[bug] folly incorrect CXX_STD when self.settings.compiler.cppstd is set #11937

Closed

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 28, 2022

prince-chrismc previously approved these changes Jul 31, 2022

View reviewed changes

conan-center-bot removed the Failed label Aug 1, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 1, 2022

uilianries reviewed Aug 3, 2022

View reviewed changes

recipes/folly/all/test_package/conanfile.py Outdated Show resolved Hide resolved

Hopobcn dismissed prince-chrismc’s stale review via 4b6cbc6 August 3, 2022 09:32

conan-center-bot removed the Failed label Aug 3, 2022

Hopobcn force-pushed the folly/fix-cppstd branch from df3f502 to 2cee966 Compare August 3, 2022 10:29

prince-chrismc approved these changes Aug 5, 2022

View reviewed changes

SSE4 approved these changes Aug 5, 2022

View reviewed changes

conan-center-bot merged commit bc9fb9c into conan-io:master Aug 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix folly CXX_STD #11938

Fix folly CXX_STD #11938

Hopobcn commented Jul 27, 2022 •

edited

This comment has been minimized.

Hopobcn commented Jul 27, 2022

This comment has been minimized.

Hopobcn commented Jul 27, 2022

SSE4 commented Jul 28, 2022

This comment has been minimized.

prince-chrismc commented Jul 31, 2022

uilianries commented Aug 1, 2022

This comment has been minimized.

uilianries commented Aug 1, 2022

prince-chrismc commented Aug 2, 2022

conan-center-bot commented Aug 3, 2022

Fix folly CXX_STD #11938

Fix folly CXX_STD #11938

Conversation

Hopobcn commented Jul 27, 2022 • edited

This comment has been minimized.

Hopobcn commented Jul 27, 2022

This comment has been minimized.

Hopobcn commented Jul 27, 2022

SSE4 commented Jul 28, 2022

This comment has been minimized.

prince-chrismc commented Jul 31, 2022

uilianries commented Aug 1, 2022

This comment has been minimized.

uilianries commented Aug 1, 2022

prince-chrismc commented Aug 2, 2022

conan-center-bot commented Aug 3, 2022

Hopobcn commented Jul 27, 2022 •

edited