-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asn1c/0.9.28 #12015
Add asn1c/0.9.28 #12015
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conan Center Index is moving toward to Conan 2.0
Some linters are checking if new PRs are minimally compatible with Conan 2.0. As some methods will be removed in the future, the linter asks to update them.
recipes/asn1c/all/conanfile.py
Outdated
from conans import ConanFile, AutoToolsBuildEnvironment, tools | ||
from conans.errors import ConanInvalidConfiguration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from conans import ConanFile, AutoToolsBuildEnvironment, tools | |
from conans.errors import ConanInvalidConfiguration | |
from conan import ConanFile | |
from conan.tools.files import get, rmdir, chdir | |
from conans import AutoToolsBuildEnvironment, tools | |
from conan.errors import ConanInvalidConfiguration |
recipes/asn1c/all/conanfile.py
Outdated
from conans.errors import ConanInvalidConfiguration | ||
import os | ||
|
||
required_conan_version = ">=1.33.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required_conan_version = ">=1.33.0" | |
required_conan_version = ">=1.47.0" |
recipes/asn1c/all/conanfile.py
Outdated
del self.info.settings.compiler | ||
|
||
def source(self): | ||
tools.get(**self.conan_data["sources"][self.version], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools.get(**self.conan_data["sources"][self.version], | |
get(self, **self.conan_data["sources"][self.version], |
recipes/asn1c/all/conanfile.py
Outdated
return self._autotools | ||
|
||
def build(self): | ||
with tools.chdir(self._source_subfolder): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with tools.chdir(self._source_subfolder): | |
with chdir(self, self._source_subfolder): |
recipes/asn1c/all/conanfile.py
Outdated
tools.rmdir(os.path.join(self.package_folder, "res", "doc")) | ||
tools.rmdir(os.path.join(self.package_folder, "res", "man")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools.rmdir(os.path.join(self.package_folder, "res", "doc")) | |
tools.rmdir(os.path.join(self.package_folder, "res", "man")) | |
rmdir(self, os.path.join(self.package_folder, "res", "doc")) | |
rmdir(self, os.path.join(self.package_folder, "res", "man")) |
@@ -0,0 +1,22 @@ | |||
from conans import ConanFile, CMake, tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from conans import ConanFile, CMake, tools | |
from conans import CMake | |
from conan import ConanFile | |
from conan.tools.build import cross_building |
cmake.build() | ||
|
||
def test(self): | ||
if not tools.cross_building(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not tools.cross_building(self): | |
if not cross_building(self): |
@uilianries , thanks for suggestions! What a coincidence, I have already prepared almost the same changes :-) Anyway I was confused by a few problems.
|
It's still not available (ported). I suggest you opening an issue to Conan client, because they are removing many things and if you explain your case, there is a chance of porting it.
True, some of them are being migrated. For instance,
Excellent question! Indeed, it deserves a documentation. In short term, you need to copy the linter folder locally (which you already have with your git clone to conan-center-index), then you need to run those steps listed on Github Actions: https://github.com/conan-io/conan-center-index/blob/master/.github/workflows/linter-conan-v2.yml#L82. Of course, don't forget to install pylint first. For instance:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All green in build 6 (
|
Specify library name and version: asn1c/0.9.28
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!