Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linter] Add first rule for test_package files #12023

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Aug 3, 2022

Rules for recipe conanfile.py and for test_package/conanfile.py should be different. Here I'm introducing the first difference (easy one):

  • recipe files require a name attribute
  • that name attribute is forbidden in test-package ones

This should serve as a starting point to add more rules.

@conan-center-bot
Copy link
Collaborator

Changes not allowed in build 1:

[linter/check_no_test_package_name.py, linter/conanv2_test_transition.py, linter/conanv2_transition.py, linter/pylintrc_testpackage, recipes/aaf/all/test_package/conanfile.py]

Split them in several pull requests if you are making changes in more than one folder..

@jgsogo
Copy link
Contributor Author

jgsogo commented Aug 3, 2022

image

💚

@jgsogo jgsogo marked this pull request as ready for review August 3, 2022 10:23
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@conan-center-bot conan-center-bot merged commit 27d78eb into conan-io:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants