Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bshoshany-thread-pool: add version 3.3.0 #12037

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

bshoshany
Copy link
Contributor

Specify library name and version: bshoshany-thread-pool/3.3.0


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@bshoshany
Copy link
Contributor Author

Looks like one of the checks fails due to incompatibility with Conan v2. What exactly do I need to change in the .py file to make it compatible? Thanks.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@bshoshany on the review page #12037, all linter topics are listed, and all them have a link to the documentation explaining your case.

To fix those errors, you just need to update some python imports which will be deprecated on Conan 2.0:

https://github.com/conan-io/conan-center-index/blob/master/docs/v2_linter.md#import-tools-from-conan

@bshoshany
Copy link
Contributor Author

Okay, I tried to follow the instructions here, hopefully this works!

@conan-center-bot
Copy link
Collaborator

All green in build 2 (790869451e1445e1fd9f69bda0cc510d47594103):

  • bshoshany-thread-pool/3.1.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.0.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.2.0@:
    All packages built successfully! (All logs)

  • bshoshany-thread-pool/3.3.0@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit b8ab57f into conan-io:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants