Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmod: modernize #12039

Merged
merged 3 commits into from
Aug 4, 2022
Merged

kmod: modernize #12039

merged 3 commits into from
Aug 4, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 4, 2022

  • handle pkgconf shared in build requirements (with VirtualBuildEnv)
  • remove most workarounds since related issues are fixed (bump min conan version accordingly: 1.48.0)
  • add a layout (basic_layout)
  • rely on autotools.autoreconf() instead of manual self.run of autoreconf
  • self.copy replaced by conan.tools.files.copy
  • CMakeToolchain/CMakeDeps/VirtualRunEnv in test_package
  • reorder methods by order of execution to provide a better understanding of recipe flow.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (62f9451d3f894b5521349702aed6339648512cae):

  • kmod/30@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12039/recipes/kmod/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12039/recipes/kmod/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12039/recipes/kmod/all/conanfile.py", line 7, in <module>
        from conans import tools as tools_legacy
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • kmod/29@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12039/recipes/kmod/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12039/recipes/kmod/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12039/recipes/kmod/all/conanfile.py", line 7, in <module>
        from conans import tools as tools_legacy
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@SSE4
Copy link
Contributor

SSE4 commented Aug 4, 2022

I am happy to see less workarounds

@conan-center-bot conan-center-bot merged commit 27e97b9 into conan-io:master Aug 4, 2022
@SpaceIm SpaceIm deleted the kmod-modernize branch August 4, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants