Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libx264/20220602] Add version #12046

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Conversation

MartinDelille
Copy link
Contributor


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

wolfee001
wolfee001 previously approved these changes Aug 4, 2022
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

I don't see that release on the snapshot page: https://download.videolan.org/pub/videolan/x264/snapshots/ Is is an official tag? Otherwise, I suggest you using the prefix cci.

@MartinDelille
Copy link
Contributor Author

No: the snapshotting service is discontinued as you can read here:
https://download.videolan.org/pub/videolan/x264/snapshots/x264-snapshot-20191218-README.txt

For information, the 20191217 version isn't compatible with ffmpeg 5.1 (#12033)

I applied the prefix as suggested.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (4217e35887d7759348f33aceae5a16262604341e):

  • libx264/cci.20220602@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12046/recipes/libx264/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12046/recipes/libx264/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12046/recipes/libx264/all/conanfile.py", line 2, in <module>
        from conans import ConanFile, tools, AutoToolsBuildEnvironment
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@uilianries uilianries added the Bump version PR bumping version without recipe modifications label Aug 5, 2022
@conan-center-bot conan-center-bot merged commit 75d5c8f into conan-io:master Aug 6, 2022
@conan-center-bot
Copy link
Collaborator

This PR has been automatically merged due Bump version or Bump dependencies label.
Read https://github.com/conan-io/conan-center-index/blob/master/docs/labels.md#bump-version to obtain more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump version PR bumping version without recipe modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants