Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android-ndk/r25] add 2022 LTS version #12047

Merged
merged 7 commits into from
Aug 6, 2022

Conversation

Bigpet
Copy link
Contributor

@Bigpet Bigpet commented Aug 4, 2022

Specify library name and version: android-ndk/r25

This is an LTS version that works on M1 Macs, this version will be the only one until the 2023 release.
So this version seems relevant to me.

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@Bigpet
Copy link
Contributor Author

Bigpet commented Aug 4, 2022

looks like the permission fixing stuff got broken, the clang++ 'binary' is literally just 5Byte big text file containing the 'clang'

nvm, just missed the symlink fix function

wolfee001
wolfee001 previously approved these changes Aug 4, 2022
Copy link
Contributor

@wolfee001 wolfee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes: ok
if you feel the energy, you could fix the issues found by the v2 linter

@conan-center-bot
Copy link
Collaborator

All green in build 7 (9ed5dd036339bf815c1a2c032096031a947229e8):

  • android-ndk/r21e@:
    All packages built successfully! (All logs)

  • android-ndk/r23b@:
    All packages built successfully! (All logs)

  • android-ndk/r22@:
    All packages built successfully! (All logs)

  • android-ndk/r22b@:
    All packages built successfully! (All logs)

  • android-ndk/r23c@:
    All packages built successfully! (All logs)

  • android-ndk/r24@:
    All packages built successfully! (All logs)

  • android-ndk/r23@:
    All packages built successfully! (All logs)

  • android-ndk/r21d@:
    All packages built successfully! (All logs)

  • android-ndk/r25@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericLemanissierBot
Copy link

I detected other pull requests that are modifying android-ndk/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[0xCF, 0xFA, 0xED, 0xFE],
[0xFE, 0xEF, 0xFA, 0xCE],
[0xCE, 0xFA, 0xED, 0xFE]
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, here and above 👍

@conan-center-bot conan-center-bot merged commit 4fad7f3 into conan-io:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants