-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android-ndk/r25] add 2022 LTS version #12047
[android-ndk/r25] add 2022 LTS version #12047
Conversation
This comment has been minimized.
This comment has been minimized.
nvm, just missed the symlink fix function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes: ok
if you feel the energy, you could fix the issues found by the v2 linter
All green in build 7 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I detected other pull requests that are modifying android-ndk/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
[0xCF, 0xFA, 0xED, 0xFE], | ||
[0xFE, 0xEF, 0xFA, 0xCE], | ||
[0xCE, 0xFA, 0xED, 0xFE] | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better, here and above 👍
Specify library name and version: android-ndk/r25
This is an LTS version that works on M1 Macs, this version will be the only one until the 2023 release.
So this version seems relevant to me.
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!