-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grpc] Use protos and binaries from requirements googleapis
and grpc-proto
(RFC)
#12062
[grpc] Use protos and binaries from requirements googleapis
and grpc-proto
(RFC)
#12062
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying grpc/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All green in build 7 (
|
Here I'm proposing some patches to consume headers and libraries from
googleapis
andgrpc-proto
instead of generating and building them ingrpc
itself. In any case there are some protos that need to be generated while buildinggrpc
because they usegrpc_cpp_plugin
(utility like protoc) that is built in thegrpc
project.With this approach, I try to prevent ODR violations when consumers of
grpc
need to use some protos fromgoogleapis
(I'm looking at you,google-cloud-cpp
project). It will also ensure that all the graph is using the same protos (and files generated from them).Finally, the patches were not as complicated as I had feared 馃槂
Big question: is it worth the effort? Is it adding too much complexity to the project?
TODO: