-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assimp: cross-compatibility conan v1 & v2 #12063
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a63f2e9assimp/5.1.6
|
It breaks Likely same issue than #12030 (comment) Is it a side effect of |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit fa3f823assimp/5.2.2
assimp/5.1.6
assimp/5.1.0
|
This reverts commit de9ebc9.
All green in build 6 (
|
Few points to notice in this PR, beyond usual migration diff:
${CONAN_LIBS}
(but in the meantime they are more explicit).ASSIMP_ENABLE_DRACO
with these patches.rapidjson
injection may break in the future, since cmake names ofCMakeDeps
in this recipe are wrong (should beRapidJSON
for config file name, andrapidjson
for the target: https://github.com/Tencent/rapidjson/blob/master/RapidJSONConfig.cmake.in).build()
doesn't work in conan v2. I guess it should be checked invalidate()
now, but don't know how to proceed.CMAKE_POLICY_DEFAULT_CMP0077
is injected to prevent CMake warnings.