Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asmjit: cross-compatibility conan v1 & v2 #12070

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 5, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 5, 2022

ERROR: asmjit/cci.20210306: Error in generate() method, line 53
	tc.variables["ASMJIT_BUILD_X86"] = self.settings.os in ["x86", "x86_64"]
	ConanException: Invalid setting 'x86' is not a valid 'settings.os' value.
Possible values are ['AIX', 'Android', 'Arduino', 'Emscripten', 'FreeBSD', 'Linux', 'Macos', 'Neutrino', 'SunOS', 'VxWorks', 'Windows', 'WindowsCE', 'WindowsStore', 'baremetal', 'iOS', 'tvOS', 'watchOS'

Ahah, removing this str() allows to catch nice typo.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (d9c54e414ca589068382baa24f94fb858dae92c0):

  • asmjit/cci.20220210@:
    All packages built successfully! (All logs)

  • asmjit/cci.20210306@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Hooks produced the following warnings for commit d9c54e4
asmjit/cci.20220210
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libasmjit.so' links to system library 'm' but it is not in cpp_info.system_libs.
asmjit/cci.20210306
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libasmjit.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 9124d58 into conan-io:master Aug 12, 2022
@SpaceIm SpaceIm deleted the asmjit-conan-v2 branch August 12, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants