New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtiff: add libtiff/4.4.0 #12083

Merged

conan-center-bot merged 6 commits into conan-io:master from madebr:libtiff-4.4.0

Aug 8, 2022

Contributor

madebr commented Aug 5, 2022

Specify library name and version: libtiff/4.4.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

madebr added 4 commits

August 5, 2022 21:15


          libtiff: add libtiff/4.4.0

0d396db


          conans.tools.Version -> conan.tools.scm.Version

beaff51


          conan.tools.get -> conan.tools.files.get

5f6f80a


          conans.tools.rmdir -> conan.tools.files.rmdir

26a9bb0

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm reviewed

View reviewed changes

recipes/libtiff/all/conanfile.py Outdated

                   def package_info(self):
                       self.cpp_info.set_property("cmake_find_mode", "both")
                       self.cpp_info.set_property("cmake_file_name", "TIFF")
                       self.cpp_info.set_property("cmake_target_name", "TIFF::TIFF")
-                      self.cpp_info.set_property("pkg_config_name", "libtiff-{}".format(tools.Version(self.version).major))
+                      self.cpp_info.set_property("pkg_config_name", "libtiff-{}".format(Version(self.version).major))

Contributor

SpaceIm Aug 5, 2022

Suggested change

      
                    self.cpp_info.set_property("pkg_config_name", "libtiff-{}".format(Version(self.version).major))
          
                    self.cpp_info.set_property("pkg_config_name", "libtiff-{}".format(Version(self.version).major))

There is no major accessor in conan.tools.scm.Version, it returns None.

Contributor Author

madebr Aug 5, 2022

major is a method of Version, so it would print e.g. <bound method Version.major of '3.4'>

Contributor

SpaceIm Aug 5, 2022 •

edited

It is not, conans.tools.Version != conan.tools.scm.Version ;)

https://docs.conan.io/en/latest/reference/conanfile/tools/scm/other.html

Contributor Author

madebr Aug 5, 2022 •

edited

I am saying major is also available on conan.tools.scm.Version, not as a property, but as a method.

Run the following in your terminal:

python -c "import conan.tools.scm; v = conan.tools.scm.Version('5.4.3.2'); print(f'{v.major=}')"

The behavior of conan.tools.scm.Version's v.major()is completely different from conans.tools.Version's .major.

Contributor

SpaceIm Aug 5, 2022

Indeed

Contributor

SpaceIm Aug 5, 2022

so something like this would work: Version(self.version).major(fill=False)

Contributor Author

madebr Aug 5, 2022

I changed it with version[0], that looked simpler to me.

SpaceIm reviewed

View reviewed changes

recipes/libtiff/all/conanfile.py Outdated

                           self.cpp_info.libs = [lib + ".dll" for lib in self.cpp_info.libs]
                       if self.settings.os in ["Linux", "Android", "FreeBSD", "SunOS", "AIX"]:
                           self.cpp_info.system_libs.append("m")
                       # TODO: to remove in conan v2 once cmake_find_package* & pkg_config generators removed
                       self.cpp_info.names["cmake_find_package"] = "TIFF"
                       self.cpp_info.names["cmake_find_package_multi"] = "TIFF"
-                      self.cpp_info.names["pkg_config"] = "libtiff-{}".format(tools.Version(self.version).major)
+                      self.cpp_info.names["pkg_config"] = "libtiff-{}".format(Version(self.version).major)

Contributor

SpaceIm Aug 5, 2022

same comment here, major returns None


          Don't use Version.major

429e9e2

This comment has been minimized.

Sign in to view

uilianries previously approved these changes

View reviewed changes

SpaceIm suggested changes

View reviewed changes

recipes/libtiff/all/conanfile.py Outdated Show resolved Hide resolved


          libtiff: bump minimum required conan version

6d2bb16

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

madebr dismissed uilianries’s stale review via

6d2bb16

August 8, 2022 10:53

SpaceIm approved these changes

View reviewed changes

uilianries approved these changes

View reviewed changes

Collaborator

conan-center-bot commented Aug 8, 2022

All green in build 4 (6d2bb165dfd71ba2cb0a2960429b68ffcce49e81):

libtiff/4.3.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py", line 4, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libtiff/4.2.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py", line 4, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libtiff/4.4.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py", line 4, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libtiff/4.0.9@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py", line 4, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libtiff/4.1.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py", line 4, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libtiff/4.0.8@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12083/recipes/libtiff/all/conanfile.py", line 4, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

conan-center-bot merged commit ba756e3 into conan-io:master

uilianries mentioned this pull request

[feature] Conan tools.scm.Version became very difficult to use conan-io/conan#11821

Closed

SpaceIm reviewed

View reviewed changes

recipes/libtiff/all/conanfile.py

    
                          self.cpp_info.libs = [lib + ".dll" for lib in self.cpp_info.libs]

                      if self.settings.os in ["Linux", "Android", "FreeBSD", "SunOS", "AIX"]:

                          self.cpp_info.system_libs.append("m")

                      # TODO: to remove in conan v2 once cmake_find_package* & pkg_config generators removed

                      self.cpp_info.names["cmake_find_package"] = "TIFF"

                      self.cpp_info.names["cmake_find_package_multi"] = "TIFF"

                      self.cpp_info.names["pkg_config"] = "libtiff-{}".format(tools.Version(self.version).major)

                      self.cpp_info.names["pkg_config"] = "libtiff-{}".format(Version(self.version)[0])

Contributor

SpaceIm Aug 10, 2022 •

edited

To "fix" once conan-io/conan#11823 released in a version we can use in cci?

Member

uilianries Aug 11, 2022

As soon as we have 1.52.0 or 1.51.2 running on CCI.

madebr deleted the libtiff-4.4.0 branch

August 10, 2022 22:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment